[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wekalist
Subject:    Re: [Wekalist] Possible bug in RemoveFrequentValues with modifyHeader
From:       Mark Hall <mhall () pentaho ! com>
Date:       2012-06-30 10:17:02
Message-ID: 4FEED21E.8020200 () pentaho ! com
[Download RAW message or body]

On 30/06/12 6:34 AM, Nate Dire wrote:
> Hi,
>
> Tested this with 3.7.6 and 3.6.7.  RemoveFrequentValues appears to
> modify missing values if modifyHeader=true.
>
> Example before/after:
>
> @data
> ?,0
> a,1
> a,0
> b,1
> ?,0
>
> weka.filters.unsupervised.instance.RemoveFrequentValues-C1-N2-H
>
> @data
> a,0
> a,1
> a,0
> b,1
> a,0
>
> Looks like setOutputFormat() needs to check for missing values before
> remapping.  I'd be happy to generate a patch and test it.  I've run
> into a couple other filter-related errors that I'd like to investigate
> anyway.

You're right - it's totally broken (with or without the -H option) for 
missing values :-) I've just committed a fix to stable-3-6 and trunk for 
this. You can get the fix in the next nightly snapshot.

Thanks for the bug report!

Cheers,
Mark.

_______________________________________________
Wekalist mailing list
Send posts to: Wekalist@list.scms.waikato.ac.nz
List info and subscription status: https://list.scms.waikato.ac.nz/mailman/listinfo/wekalist
List etiquette: http://www.cs.waikato.ac.nz/~ml/weka/mailinglist_etiquette.html
[prev in list] [next in list] [prev in thread] [next in thread]