[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webmin-l
Subject:    Re: [webmin-l] ftps backup feature
From:       "Jamie Cameron" <jcameron () webmin ! com>
Date:       2012-03-15 22:15:46
Message-ID: 1331849746.18584 () webmin ! com
[Download RAW message or body]

On 15/Mar/2012 12:04 Csere M=E1ty=E1s <cserem@gmail.com> wrote ..
> 
> 
> 2012.03.15. 19:41 keltez=E9ssel, Jamie Cameron =EDrta:
>  > On 15/Mar/2012 08:13 Csere M=E1ty=E1s <cserem@gmail.com> wrote ..
>  >>
>  >> > However, switching my backups from ftp to ssh raised a problem with
>  >> the *dom/*info files:
>  >> > With ftp everything is nice and dandy, the *dom/*info files are
>  >> created in the backup dir with the domain:
>  >> >
>  >> I've had a little time to dig deeper.
>  >> Editing webmin-1.580/virtual-server//backups-lib.pl like this seems to
>  >> resolve the .dom /.info issue:
>  >>
>  >> 665c665
>  >> < &scp_copy($infotemp, $r.".info", $pass,
>  >> ---
>  >> > &scp_copy($infotemp, $r."/".$df.".info", $pass,
>  >> 667c667
>  >> < &scp_copy($domtemp, $r.".dom", $pass,
>  >> ---
>  >> > &scp_copy($domtemp, $r."/".$df.".dom", $pass,
>  >>
>  >> > The behaviour is the same with  "Create destination directory?" on
>  >> and off too. (BTW. is this parameter still active? Without enabling it
>  >> it still creates directories.)
>  >> Seems like directory creation is the default behaveiour for remote
>  >> targets :)
>  >>
>  >> Jamie, could you verify / merge into the next release?
>  > Are you sure that change is needed? I'm unclear as to exactly
>  > what it fixes ..
> 
> No, I am not :)
> 
> But with this change,  I get the same result from:
>   virtualmin backup-domain --dest 
> ssh://user:pass@backuphost:backupdir/test --domain dom1.com --domain 
> dom2.com --all-features --newformat --onebyone
> like with
>   virtualmin backup-domain --dest 
> ftp://user:pass@backuphost:backupdir/test --domain dom1.com --domain 
> dom2.com --all-features --newformat --onebyone
> 
> Without it the there is a test.info and test.dom created in the 
> backupdir if i use ssh as dest.

Ok, makes sense ... I actually fixed this already, and will include the
fix in the next Virtualmin release.

 - Jamie


------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure

-
Forwarded by the Webmin mailing list at webadmin-list@lists.sourceforge.net
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-list


[prev in list] [next in list] [prev in thread] [next in thread]