[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-unassigned
Subject: [Webkit-unassigned] [Bug 264013] New: [style-checker] test/expectations errors surfaced twice
From: bugzilla-daemon () webkit ! org
Date: 2023-10-31 23:30:28
Message-ID: bug-264013-2851 () https ! bugs ! webkit ! org/
[Download RAW message or body]
--16987950270.A343B.3974
Date: Tue, 31 Oct 2023 16:30:27 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.webkit.org/
Auto-Submitted: auto-generated
https://bugs.webkit.org/show_bug.cgi?id=264013
Bug ID: 264013
Summary: [style-checker] test/expectations errors surfaced
twice
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
Assignee: webkit-unassigned@lists.webkit.org
Reporter: a_protyasha@apple.com
CC: a_protyasha@apple.com,
webkit-bug-importer@group.apple.com
The style checker invokes TestExpectation errors twice for me. It's not a serious \
bug, but does add some noise! Here's a sample of what it looks like:
```
% git webkit pr --no-rebase --no-commit
ERROR: Tools/TestRunnerShared/WPTFunctions.cpp:29: Alphabetical sorting problem. \
[build/include_order] [4]
ERROR: Tools/TestRunnerShared/WPTFunctions.h:38: The parameter name "url" adds no \
information, so it should be removed. [readability/parameter_name] \
[5]
ERROR: Tools/WebKitTestRunner/mac/TestControllerMac.mm:36: Alphabetical sorting \
problem. [build/include_order] [4]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:601: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:602: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:603: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:604: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:605: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:606: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:607: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:608: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:601: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:602: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:603: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:604: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:605: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:606: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:607: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:608: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5] ```
Notice how the errors in the `[test/expectations]` category are duplicated, once with \
a relative path from the repository root, and once with an absolute path.
--
You are receiving this mail because:
You are the assignee for the bug.
--16987950270.A343B.3974
Date: Tue, 31 Oct 2023 16:30:27 -0700
MIME-Version: 1.0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.webkit.org/
Auto-Submitted: auto-generated
<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [style-checker] test/expectations errors surfaced twice"
href="https://bugs.webkit.org/show_bug.cgi?id=264013">264013</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[style-checker] test/expectations errors surfaced twice
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>a_protyasha@apple.com
</td>
</tr>
<tr>
<th>CC</th>
<td>a_protyasha@apple.com, webkit-bug-importer@group.apple.com
</td>
</tr></table>
<p>
<div>
<pre>The style checker invokes TestExpectation errors twice for me. It's not \
a serious bug, but does add some noise! Here's a sample of what it looks like:
```
% git webkit pr --no-rebase --no-commit
ERROR: Tools/TestRunnerShared/WPTFunctions.cpp:29: Alphabetical sorting problem. \
[build/include_order] [4]
ERROR: Tools/TestRunnerShared/WPTFunctions.h:38: The parameter name "url" \
adds no information, so it should be removed. \
[readability/parameter_name] [5]
ERROR: Tools/WebKitTestRunner/mac/TestControllerMac.mm:36: Alphabetical sorting \
problem. [build/include_order] [4]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:601: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:602: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:603: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:604: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:605: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:606: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:607: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:608: Unrecognized expectation \
"ImageonlyFailure" [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:601: \
Unrecognized expectation "ImageonlyFailure" \
[test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:602: \
Unrecognized expectation "ImageonlyFailure" \
[test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:603: \
Unrecognized expectation "ImageonlyFailure" \
[test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:604: \
Unrecognized expectation "ImageonlyFailure" \
[test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:605: \
Unrecognized expectation "ImageonlyFailure" \
[test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:606: \
Unrecognized expectation "ImageonlyFailure" \
[test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:607: \
Unrecognized expectation "ImageonlyFailure" \
[test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:608: \
Unrecognized expectation "ImageonlyFailure" [test/expectations] [5] ```
Notice how the errors in the `[test/expectations]` category are duplicated, once with \
a relative path from the repository root, and once with an absolute path.</pre> \
</div> </p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>
--16987950270.A343B.3974--
_______________________________________________
webkit-unassigned mailing list
webkit-unassigned@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-unassigned
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic