[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-unassigned
Subject:    [Webkit-unassigned] [Bug 248564] New: Refactor RenderBox:sizesLogicalWidthToFitContent()
From:       bugzilla-daemon () webkit ! org
Date:       2022-11-30 23:30:49
Message-ID: bug-248564-2851 () https ! bugs ! webkit ! org/
[Download RAW message or body]

--1669851049.0A146.13761
Date: Wed, 30 Nov 2022 15:30:49 -0800
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.webkit.org/
Auto-Submitted: auto-generated

https://bugs.webkit.org/show_bug.cgi?id=248564

            Bug ID: 248564
           Summary: Refactor RenderBox:sizesLogicalWidthToFitContent()
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned@lists.webkit.org
          Reporter: ahmad.saleem792@gmail.com
                CC: bfulgham@webkit.org, simon.fraser@apple.com,
                    zalan@apple.com

Hi Team,

While going through Blink Commit, I came across following refactoring to remove \
comment and logic, which was not clear.

Blink Commit - https://src.chromium.org/viewvc/blink?revision=170695&view=revision

Webkit GitHub - https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2740 \
& https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2812 \
& https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2822


and https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.h#L458


It will remove comment about being strange code.

Just wanted to raise this bug so it can be tried.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
--1669851049.0A146.13761
Date: Wed, 30 Nov 2022 15:30:49 -0800
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.webkit.org/
Auto-Submitted: auto-generated

<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Refactor RenderBox:sizesLogicalWidthToFitContent()"
   href="https://bugs.webkit.org/show_bug.cgi?id=248564">248564</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Refactor RenderBox:sizesLogicalWidthToFitContent()
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>WebKit
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>Safari Technology Preview
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P2
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Layout and Rendering
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>webkit-unassigned&#64;lists.webkit.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>ahmad.saleem792&#64;gmail.com
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>bfulgham&#64;webkit.org, simon.fraser&#64;apple.com, \
zalan&#64;apple.com  </td>
        </tr></table>
      <p>
        <div>
        <pre>Hi Team,

While going through Blink Commit, I came across following refactoring to remove \
comment and logic, which was not clear.

Blink Commit - <a href="https://src.chromium.org/viewvc/blink?revision=170695&amp;view \
=revision">https://src.chromium.org/viewvc/blink?revision=170695&amp;view=revision</a>


Webkit GitHub - <a href="https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f \
3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2740">https://github.com/Web \
Kit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2740</a> \
&amp; <a href="https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff1497 \
4929491/Source/WebCore/rendering/RenderBox.cpp#L2812">https://github.com/WebKit/WebKit \
/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2812</a> \
&amp; <a href="https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff1497 \
4929491/Source/WebCore/rendering/RenderBox.cpp#L2822">https://github.com/WebKit/WebKit \
/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2822</a>


and <a href="https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff149749 \
29491/Source/WebCore/rendering/RenderBox.h#L458">https://github.com/WebKit/WebKit/blob \
/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.h#L458</a>


It will remove comment about being strange code.

Just wanted to raise this bug so it can be tried.

Thanks!</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>
--1669851049.0A146.13761--



_______________________________________________
webkit-unassigned mailing list
webkit-unassigned@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-unassigned


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic