[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-unassigned
Subject: [Webkit-unassigned] [Bug 220508] [META][SOUP] Support libsoup3
From: bugzilla-daemon () webkit ! org
Date: 2021-02-28 14:10:33
Message-ID: bug-220508-2851-inPQu7LIyW () https ! bugs ! webkit ! org/
[Download RAW message or body]
--1614521433.EAfA7.7546
Date: Sun, 28 Feb 2021 06:10:33 -0800
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.webkit.org/
Auto-Submitted: auto-generated
https://bugs.webkit.org/show_bug.cgi?id=220508
gabriele balducci <balducci@units.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |balducci@units.it
--- Comment #1 from gabriele balducci <balducci@units.it> ---
building 2.31.90 with -DUSE_SOUP2=OFF fails for me because soup
version 2.4 is still hardcoded in the following files:
----8<----
Tools/gtkdoc/generate-gtkdoc
Source/WebKit/PlatformGTK.cmake
Source/WebKit/gtk/webkit2gtk.pc.in
Source/WebKit/gtk/webkit2gtk-web-extension.pc.in
---->8----
brute force fix of those definitions makes my build succeed; eg:
----8<----
diff -c ./Source/WebKit/PlatformGTK.cmake.REALLY_SOUP_3 \
./Source/WebKit/PlatformGTK.cmake
*** ./Source/WebKit/PlatformGTK.cmake.REALLY_SOUP_3 2021-02-28 10:15:27.680399591 \
+0100
--- ./Source/WebKit/PlatformGTK.cmake 2021-02-28 10:15:27.684399609 +0100
***************
*** 684,690 ****
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-2.4
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
--- 684,690 ----
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-3.0
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
***************
*** 693,699 ****
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-2.4
--pkg-export=webkit2gtk-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
--- 693,699 ----
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-3.0
--pkg-export=webkit2gtk-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
***************
*** 731,737 ****
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-2.4
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
--- 731,737 ----
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-3.0
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
***************
*** 741,747 ****
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-2.4
--pkg-export=webkit2gtk-web-extension-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
--- 741,747 ----
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-3.0
--pkg-export=webkit2gtk-web-extension-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
---->8----
and so on.
Building on linux with:
----8<----
-DCMAKE_CXX_FLAGS="-fpermissive"
-DPORT=GTK
-DCMAKE_BUILD_TYPE=Release
-DENABLE_CREDENTIAL_STORAGE=OFF
-DENABLE_GEOLOCATION=OFF
-DUSE_LIBNOTIFY=OFF
-DUSE_LIBHYPHEN=OFF
-DENABLE_FTL_JIT=ON
-DUSE_WOFF2=OFF
-DENABLE_JIT=ON
-DUSE_OPENJPEG=OFF
-DUSE_WPE_RENDERER=OFF
-DENABLE_BUBBLEWRAP_SANDBOX=OFF
-DUSE_SYSTEMD=OFF
-DENABLE_GAMEPAD=OFF
-DUSE_LD_GOLD=OFF
-DUSE_SOUP2=OFF
---->8----
thanks
ciao
-gabriele
--
You are receiving this mail because:
You are the assignee for the bug.
--1614521433.EAfA7.7546
Date: Sun, 28 Feb 2021 06:10:33 -0800
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.webkit.org/
Auto-Submitted: auto-generated
<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:balducci@units.it" \
title="gabriele balducci <balducci@units.it>"> <span class="fn">gabriele \
balducci</span></a> </span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [META][SOUP] Support libsoup3"
href="https://bugs.webkit.org/show_bug.cgi?id=220508">bug 220508</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>balducci@units.it
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [META][SOUP] Support libsoup3"
href="https://bugs.webkit.org/show_bug.cgi?id=220508#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [META][SOUP] Support libsoup3"
href="https://bugs.webkit.org/show_bug.cgi?id=220508">bug 220508</a>
from <span class="vcard"><a class="email" \
href="mailto:balducci@units.it" title="gabriele balducci \
<balducci@units.it>"> <span class="fn">gabriele balducci</span></a> \
</span></b>
<pre>building 2.31.90 with -DUSE_SOUP2=OFF fails for me because soup
version 2.4 is still hardcoded in the following files:
----8<----
Tools/gtkdoc/generate-gtkdoc
Source/WebKit/PlatformGTK.cmake
Source/WebKit/gtk/webkit2gtk.pc.in
Source/WebKit/gtk/webkit2gtk-web-extension.pc.in
---->8----
brute force fix of those definitions makes my build succeed; eg:
----8<----
diff -c ./Source/WebKit/PlatformGTK.cmake.REALLY_SOUP_3 \
./Source/WebKit/PlatformGTK.cmake
*** ./Source/WebKit/PlatformGTK.cmake.REALLY_SOUP_3 2021-02-28 10:15:27.680399591 \
+0100
--- ./Source/WebKit/PlatformGTK.cmake 2021-02-28 10:15:27.684399609 +0100
***************
*** 684,690 ****
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-2.4
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
--- 684,690 ----
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-3.0
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
***************
*** 693,699 ****
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-2.4
--pkg-export=webkit2gtk-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
--- 693,699 ----
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-3.0
--pkg-export=webkit2gtk-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
***************
*** 731,737 ****
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-2.4
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
--- 731,737 ----
--nsversion=${WEBKITGTK_API_VERSION}
--include=GObject-2.0
--include=Gtk-${GTK_API_VERSION}.0
! --include=Soup-3.0
--include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
--library=webkit2gtk-${WEBKITGTK_API_VERSION}
--library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
***************
*** 741,747 ****
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-2.4
--pkg-export=webkit2gtk-web-extension-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
--- 741,747 ----
--no-libtool
--pkg=gobject-2.0
--pkg=${GTK_PKGCONFIG_PACKAGE}
! --pkg=libsoup-3.0
--pkg-export=webkit2gtk-web-extension-${WEBKITGTK_API_VERSION}
--output=${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
${GIR_SOURCES_TOP_DIRS}
---->8----
and so on.
Building on linux with:
----8<----
-DCMAKE_CXX_FLAGS="-fpermissive"
-DPORT=GTK
-DCMAKE_BUILD_TYPE=Release
-DENABLE_CREDENTIAL_STORAGE=OFF
-DENABLE_GEOLOCATION=OFF
-DUSE_LIBNOTIFY=OFF
-DUSE_LIBHYPHEN=OFF
-DENABLE_FTL_JIT=ON
-DUSE_WOFF2=OFF
-DENABLE_JIT=ON
-DUSE_OPENJPEG=OFF
-DUSE_WPE_RENDERER=OFF
-DENABLE_BUBBLEWRAP_SANDBOX=OFF
-DUSE_SYSTEMD=OFF
-DENABLE_GAMEPAD=OFF
-DUSE_LD_GOLD=OFF
-DUSE_SOUP2=OFF
---->8----
thanks
ciao
-gabriele</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>
--1614521433.EAfA7.7546--
_______________________________________________
webkit-unassigned mailing list
webkit-unassigned@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-unassigned
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic