[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review granted: [Bug 273968] AX: AXObjectCache::postPlatformNotification should tak
From:       bugzilla-daemon () webkit ! org
Date:       2024-05-10 3:53:32
Message-ID: bug-273968-0-K1oRUK9T0O () https ! bugs ! webkit ! org/
[Download RAW message or body]

Darin Adler <darin@apple.com> has granted Andres Gonzalez
<andresg_22@apple.com>'s request for review:
Bug 273968: AX: AXObjectCache::postPlatformNotification should take an
AccessibilityObject not an AXCoreObject.
https://bugs.webkit.org/show_bug.cgi?id=273968

Attachment 471346: Patch

https://bugs.webkit.org/attachment.cgi?id=471346&action=review




--- Comment #4 from Darin Adler <darin@apple.com> ---
Comment on attachment 471346
  --> https://bugs.webkit.org/attachment.cgi?id=471346
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471346&action=review

> Source/WebCore/accessibility/AXObjectCache.h:598
> +    void postPlatformNotification(const AccessibilityObject&,
AXNotification);

How about having this take a reference and not a const reference? Could avoid
the const_cast and I think it makes logical sense either way.
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]