[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review granted: [Bug 273898] [Cleanup] Remove RenderBox::hasOverridingLogicalHeight
From:       bugzilla-daemon () webkit ! org
Date:       2024-05-08 22:04:45
Message-ID: bug-273898-0-xSsl6ZkyIW () https ! bugs ! webkit ! org/
[Download RAW message or body]

Simon Fraser (smfr) <simon.fraser@apple.com> has granted  review:
Bug 273898: [Cleanup] Remove RenderBox::hasOverridingLogicalHeightLength
https://bugs.webkit.org/show_bug.cgi?id=273898

Attachment 471325: Patch

https://bugs.webkit.org/attachment.cgi?id=471325&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser@apple.com> ---
Comment on attachment 471325
  --> https://bugs.webkit.org/attachment.cgi?id=471325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471325&action=review

> Source/WebCore/rendering/RenderBox.cpp:1414
> +    return iterator != gOverridingLogicalHeightLengthMap->end() ?
std::make_optional(iterator->value) : std::nullopt;

Use getOptional()
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]