[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review denied: [Bug 218381] [WTF] Coding style issues in MediaTime.h : [Attachment 
From:       bugzilla-daemon () webkit ! org
Date:       2020-10-31 4:03:10
Message-ID: bug-218381-0-8iaWRi7iXX () https ! bugs ! webkit ! org/
[Download RAW message or body]

Yusuke Suzuki <ysuzuki@apple.com> has denied Philippe Normand
<pnormand@igalia.com>'s request for review:
Bug 218381: [WTF] Coding style issues in MediaTime.h
https://bugs.webkit.org/show_bug.cgi?id=218381

Attachment 412731: Patch

https://bugs.webkit.org/attachment.cgi?id=412731&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki@apple.com> ---
Comment on attachment 412731
  --> https://bugs.webkit.org/attachment.cgi?id=412731
Patch

I think these functions are small and should be inline function. So defining in
the header is better. Let's remove WTF_EXPORT_PRIVATE from the class, and
annotate some of actually exported functions with WTF_EXPORT_PRIVATE.
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]