[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review granted: [Bug 216012] Webpages flash when switching between windows : [Attac
From:       bugzilla-daemon () webkit ! org
Date:       2020-09-04 16:43:42
Message-ID: bug-216012-0-JBrB9hmE6e () https ! bugs ! webkit ! org/
[Download RAW message or body]

Tim Horton <thorton@apple.com> has granted Sihui Liu <sihui_liu@apple.com>'s
request for review:
Bug 216012: Webpages flash when switching between windows
https://bugs.webkit.org/show_bug.cgi?id=216012

Attachment 407817: Patch

https://bugs.webkit.org/attachment.cgi?id=407817&action=review




--- Comment #34 from Tim Horton <thorton@apple.com> ---
Comment on attachment 407817
  --> https://bugs.webkit.org/attachment.cgi?id=407817
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407817&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:494
> +    bool hasScheduledOnObserver =
m_activityStateChangeDispatcher->isScheduled();

"on"?

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:520
> +    if (![CATransaction currentState]) {

Both of the places you check this should have comments, since it's very very
weird.

Maybe we should just adjust the tests instead? Is this a state you can ever get
to in "reality"?
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]