[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review granted: [Bug 173860] [iOS DnD] Text indicators for dragged links should alw
From:       bugzilla-daemon () webkit ! org
Date:       2017-06-30 23:36:26
Message-ID: bug-173860-0-toGwZrX13B () https ! bugs ! webkit ! org/
[Download RAW message or body]

Tim Horton <thorton@apple.com> has granted Wenson Hsieh
<wenson_hsieh@apple.com>'s request for review:
Bug 173860: [iOS DnD] Text indicators for dragged links should always be
legible if the link is legible
https://bugs.webkit.org/show_bug.cgi?id=173860

Attachment 314315: Patch

https://bugs.webkit.org/attachment.cgi?id=314315&action=review




--- Comment #9 from Tim Horton <thorton@apple.com> ---
Comment on attachment 314315
  --> https://bugs.webkit.org/attachment.cgi?id=314315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314315&action=review

> Source/WebCore/page/TextIndicator.cpp:230
> +	   auto& color = node->renderer()->style().color();

Any need for a renderer null check? Any chance to get here with an anonymous
element?
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]