[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review denied: [Bug 87859] Bug: Negative SVG rect rx, ry corner radii values aren't
From:       bugzilla-daemon () webkit ! org
Date:       2012-05-31 22:57:28
Message-ID: 20120531225728.7D85B131B8AF () lists ! macosforge ! org
[Download RAW message or body]

Dirk Schulze <krit@webkit.org> has denied Hans Muller
<giles_joplin@yahoo.com>'s request for review:
Bug 87859: Bug: Negative SVG rect rx,ry corner radii values aren't handled
correctly
https://bugs.webkit.org/show_bug.cgi?id=87859

Attachment 145163: Patch
https://bugs.webkit.org/attachment.cgi?id=145163&action=review

------- Additional Comments from Dirk Schulze <krit@webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145163&action=review


Looks good to me. Just snippets to get r+.

> LayoutTests/svg/custom/rect-negative-corner-radii-expected.svg:2
> +<svg xmlns:svg="http://www.w3.org/2000/svg"
xmlns="http://www.w3.org/2000/svg" version="1.0" width="500" height="500">

xmlns:svg="http://www.w3.org/2000/svg" Is unnecessary.

> LayoutTests/svg/custom/rect-negative-corner-radii.svg:2
> +<svg xmlns:svg="http://www.w3.org/2000/svg"
xmlns="http://www.w3.org/2000/svg" version="1.0" width="500" height="500">

Ditto.
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]