[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review denied: [Bug 54969] [Chromium] Implement
From:       bugzilla-daemon () webkit ! org
Date:       2011-02-28 23:07:19
Message-ID: 20110228230719.8F6BE35776B () lists ! macosforge ! org
[Download RAW message or body]

Dimitri Glazkov (Google) <dglazkov@chromium.org> has denied Robert Sesek
<rsesek@chromium.org>'s request for review:
Bug 54969: [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput
implementation
https://bugs.webkit.org/show_bug.cgi?id=54969

Attachment 83828: Patch
https://bugs.webkit.org/attachment.cgi?id=83828&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov@chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83828&action=review

Pls fix EWS breakage and help to unduplicate.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:2298
> +// This function is copied from /WebKit2/WebPage/mac/WebPageMac.mm.

Sounds like this should just live in WebCore. There's nothing WebKitty here.
Can you move and unduplicate?

> Source/WebKit/chromium/src/WebFrameImpl.cpp:2325
> +bool WebFrameImpl::getLocationAndLengthFromRange(Range* range, unsigned&
location, unsigned& length) const

Ditto.

> Source/WebKit/chromium/src/mac/WebTextHelper.mm:74
> +// This function is copied from
/WebKit/mac/Misc/WebNSAttributedStringExtras.mm.

Can we just compile WebNSAttributedStringExtras.mm?
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]