[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review granted: [Bug 54893] Remove
From:       bugzilla-daemon () webkit ! org
Date:       2011-02-28 22:53:52
Message-ID: 20110228225352.B11D8357667 () lists ! macosforge ! org
[Download RAW message or body]

Darin Adler <darin@apple.com> has granted jpu@apple.com's request for review:
Bug 54893: Remove CorrectionIndicator markers sooner.
https://bugs.webkit.org/show_bug.cgi?id=54893

Attachment 84124: Proposed patch (v3)
https://bugs.webkit.org/attachment.cgi?id=84124&action=review

------- Additional Comments from Darin Adler <darin@apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84124&action=review

> Source/WebCore/dom/DocumentMarkerController.cpp:585
> +inline bool
DocumentMarkerController::possiblyHasMarkers(DocumentMarker::MarkerTypes types)

> +{
> +    return m_possiblyExistingMarkerTypes & types;
> +}

Because this is an inline, I think we might need it to be at the top of the
file, before any callers. Not sure. I think the EWS bot may tell us if I'm
right.

> Source/WebCore/dom/DocumentMarkerController.h:86
> +    MarkerMap m_markers;
> +    // Provide a quick way to determine whether a particular marker type is
absent without going through the map.
> +    DocumentMarker::MarkerTypes m_possiblyExistingMarkerTypes;
> +    bool possiblyHasMarkers(DocumentMarker::MarkerTypes);

Normally we put the data members in a separate paragraph after all the function
members.
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-reviews

[prev in list] [next in list] [prev in thread] [next in thread]