[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-reviews
Subject:    [webkit-reviews] review denied: [Bug 46939] [chromium] Give
From:       bugzilla-daemon () webkit ! org
Date:       2010-09-30 22:13:37
Message-ID: 20100930221337.F41EC42242A5 () gamma ! macosforge ! org
[Download RAW message or body]

Darin Fisher (:fishd, Google) <fishd@chromium.org> has denied Nico Weber
<thakis@chromium.org>'s request for review:
Bug 46939: [chromium] Give WebString an operator<< when building unit tests
https://bugs.webkit.org/show_bug.cgi?id=46939

Attachment 69389: Patch
https://bugs.webkit.org/attachment.cgi?id=69389&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd@chromium.org>
I'm not thrilled about using he UNIT_TEST macro in WebKit API headers.	I'm OK
with this change otherwise, but I wonder... is #include <iosfwd> really enough
to support the implementation of this function?
_______________________________________________
webkit-reviews mailing list
webkit-reviews@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-reviews
[prev in list] [next in list] [prev in thread] [next in thread]