[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Suggesting to enable paint timing by default
From: Noam Rosenthal <noam () webkit ! org>
Date: 2020-08-20 8:25:53
Message-ID: CAGttnEWsqa-2_w5ZPXNBVA9GFihP=uXLuzieuYkhWfjqu-PRYA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Thu, 20 Aug 2020 at 6:26 Maciej Stachowiak <mjs@apple.com> wrote:
>
>
> On Jul 17, 2020, at 12:12 AM, Noam Rosenthal <noam@webkit.org> wrote:
>
>
>
> On Thu, Jul 16, 2020 at 11:03 PM Keith Miller <keith_miller@apple.com>
> wrote:
>
>> Results appear to be neutral on the page load time benchmark, so you
>> should be good on that front. I don't know who the best person to vet the
>> maturity of the code is though, sorry.
>>
>
> Thanks a lot Keith, I appreciate it!
> @Maciej Stachowiak <mjs@apple.com>, what would be a good way to assert
> whether the code maturity is good enough to enable paint timing by default?
> The original code was reviewed by smfr and initially by zalan. It's
> covered by over 30 tests, mostly WPT, and A/B tests show no effect on load
> times as per Keith's check.
> Would asking for additional reviews be the next step? From whom?
>
>
> At this point, if a reviewer approves a patch to enable it by default on
> trunk, I think you are good to go.
>
> As a courtesy to Apple, I'd ask you to hold off on landing until
> mid-September, but that is optional.
>
Great
The patch has already been reviewed,
I will re-land it in mid September.
Thank you!
>
> - Maciej
>
[Attachment #5 (text/html)]
<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Thu, 20 Aug 2020 at 6:26 Maciej Stachowiak <<a \
href="mailto:mjs@apple.com">mjs@apple.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote \
type="cite"><div>On Jul 17, 2020, at 12:12 AM, Noam Rosenthal <<a \
href="mailto:noam@webkit.org" target="_blank">noam@webkit.org</a>> \
wrote:</div><br><div><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 16, 2020 at 11:03 \
PM Keith Miller <<a href="mailto:keith_miller@apple.com" \
target="_blank">keith_miller@apple.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div>Results \
appear to be neutral on the page load time benchmark, so you should be good on that \
front. I don't know who the best person to vet the maturity of the code is though, \
sorry.</div></blockquote><div><br></div><div>Thanks a lot Keith, I appreciate \
it!</div><div><a class="gmail_plusreply" id="m_-5942134761871284904plusReplyChip-0" \
href="mailto:mjs@apple.com" target="_blank">@Maciej Stachowiak</a>, what would be a \
good way to assert whether the code maturity is good enough to enable paint timing by \
default?<br>The original code was reviewed by smfr and initially by zalan. It's \
covered by over 30 tests, mostly WPT, and A/B tests show no effect on load times as \
per Keith's check.<br>Would asking for additional reviews be the next step? From \
whom?<br></div></div></div></div></blockquote></div><br><div>At this point, if a \
reviewer approves a patch to enable it by default on trunk, I think you are good to \
go.</div><div><br></div><div>As a courtesy to Apple, I'd ask you to hold off on \
landing until mid-September, but that is optional.</div></div></blockquote><div \
dir="auto"><br></div><div dir="auto">Great</div><div dir="auto">The patch has already \
been reviewed,</div><div dir="auto">I will re-land it in mid September.</div><div \
dir="auto">Thank you!</div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
style="word-wrap:break-word;line-break:after-white-space"><div></div></div><div \
style="word-wrap:break-word;line-break:after-white-space"><div><br></div><div> - \
Maciej</div></div></blockquote></div></div>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic