[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force
From: Alexey Proskuryakov <ap () webkit ! org>
Date: 2020-06-18 0:21:01
Message-ID: C2C96F80-ED7E-4DED-B5DC-A976E647BDC1 () webkit ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I frequently find it critically useful to see stack traces from debug builds, because \
of no inlining. So I don't think that we should do this. A local build does not help \
when the issue is not readily reproducible.
- Alexey
> 17 июня 2020 г., в 1:36 PM, Mark Lam <mark.lam@apple.com> написал(а):
>
> Hi folks,
>
> We're planning to switch the JSC EWS bot and build.webkit.org \
> <http://build.webkit.org/> Debug build and test bots to building with the following \
> set first:
> ./Tools/Scripts/set-webkit-configuration --force-opt=O3
>
> This means the Debug builds will be built with optimization level forced to O3.
>
> Why are we doing this?
> 1. So that the JSC EWS will start catching ASSERT failures.
> 2. JSC stress test Debug bots have been timing out and not running tests at all. \
> Hopefully, this change will fix this issue. 3. Tests will run to completion faster \
> and we'll catch regressions sooner.
> The downside: crash stack traces will be like Release build stack traces. But I \
> don't think we should let this deter us. It's not like there's no stack \
> information. And just as we do with debugging Release build test failures, we can \
> always do a Debug build locally to do our debugging.
> We would like to apply this change to all Debug build and test bots, not just the \
> JSC ones. Does anyone strongly object to this change?
> Thanks.
>
> Cheers,
> Mark
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
[Attachment #5 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class=""><div class=""><br class=""></div><div \
class="">I frequently find it critically useful to see stack traces from debug \
builds, because of no inlining. So I don't think that we should do this. A local \
build does not help when the issue is not readily reproducible.</div><br \
class=""><div><div class=""> <div style="color: rgb(0, 0, 0); letter-spacing: normal; \
orphans: auto; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: \
after-white-space;" class=""><div class="">- Alexey</div><div class=""><br \
class=""></div></div><br class="Apple-interchange-newline">
</div>
<blockquote type="cite" class=""><div class="">17 июня 2020 г., в 1:36 PM, Mark \
Lam <<a href="mailto:mark.lam@apple.com" class="">mark.lam@apple.com</a>> \
написал(а):</div><br class="Apple-interchange-newline"><div class=""><meta \
http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div \
style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: \
after-white-space;" class="">Hi folks,<br class=""><br class="">We're planning to \
switch the JSC EWS bot and <a href="http://build.webkit.org/" \
class="">build.webkit.org</a> Debug build and test bots to building with the \
following set first:<br class="">./Tools/Scripts/set-webkit-configuration \
--force-opt=O3<br class=""><br class="">This means the Debug builds will be built \
with optimization level forced to O3.<br class=""><br class="">Why are we doing \
this?<br class="">1. So that the JSC EWS will start catching ASSERT failures.<br \
class="">2. JSC stress test Debug bots have been timing out and not running tests at \
all. Hopefully, this change will fix this issue.<br class="">3. Tests will run \
to completion faster and we'll catch regressions sooner.<br class=""><br class="">The \
downside: crash stack traces will be like Release build stack traces. But I \
don't think we should let this deter us. It's not like there's no stack \
information. And just as we do with debugging Release build test failures, we \
can always do a Debug build locally to do our debugging.<br class=""><br class="">We \
would like to apply this change to all Debug build and test bots, not just the JSC \
ones. Does anyone strongly object to this change?<br class=""><br \
class="">Thanks.<br class=""><br class="">Cheers,<br class="">Mark<div class=""><br \
class=""></div></div>_______________________________________________<br \
class="">webkit-dev mailing list<br class=""><a \
href="mailto:webkit-dev@lists.webkit.org" class="">webkit-dev@lists.webkit.org</a><br \
class="">https://lists.webkit.org/mailman/listinfo/webkit-dev<br \
class=""></div></blockquote></div><br class=""><div class=""> <div style="color: \
rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: \
0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space;" class=""><div class=""><br \
class=""></div></div></div></body></html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic