[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Suggesting to enable paint timing by default
From: Yoav Weiss <yoav () yoav ! ws>
Date: 2020-05-27 9:03:53
Message-ID: CACj=BEjwC1_6XJ4gvPVSUpJhrY1VsJeak-_VCmXcTocV79BAcg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
+Ryosuke Niwa <rniwa@webkit.org> +Alex Christensen <achristensen@apple.com> who
were involved in the spec discussions.
On Wed, May 27, 2020 at 10:29 AM Noam Rosenthal <noam@webkit.org> wrote:
>
>
> Following up on this.
>
>> FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak <mjs@apple.com>
>> wrote:
>>
>>>
>>>
>>> On May 11, 2020, at 9:53 PM, Noam Rosenthal <noam@webkit.org> wrote:
>>>
>>>
>>>
>>> On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak <mjs@apple.com> wrote:
>>>
>>>>
>>>> I noticed from comments in one of the Radars that the patch may result
>>>> in an additional "fake paint", so it should probably be performance tested.
>>>> Have you done any testing?
>>>>
>>> I've tested it locally, I haven't noticed any significant side effect,
>>> because in complex situations the fake paint only happens once per page and
>>> bails early once contentfulness is detected. but I can run any additional
>>> test needed.
>>>
>>>
>>>> We'll likely want to A/B some of Apple's page load speed benchmarks.
>>>>
>>> A/B testing load speed sounds sensible. How do we go about doing that?
>>>
>>>
>>> Unfortunately our page load speed benchmarks are not public because they
>>> incorporate captured page content, which we can't freely redistribute.
>>>
>>> So, can someone else from Apple review that the code is mature enough
> for this? Simon had reviewed the original patch. Maybe Zalan/Darin?
>
> A helpful person from Apple may be able to set up an A/B test for this
>>> patch.
>>>
>> What's required to ask for help from a helpful person at Apple? :)
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
[Attachment #5 (text/html)]
<div dir="ltr"><a class="gmail_plusreply" id="plusReplyChip-0" \
href="mailto:rniwa@webkit.org" tabindex="-1">+Ryosuke Niwa</a> <a \
class="gmail_plusreply" id="plusReplyChip-1" href="mailto:achristensen@apple.com" \
tabindex="-1">+Alex Christensen</a> who were involved in the spec \
discussions.<br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Wed, May 27, 2020 at 10:29 AM Noam Rosenthal <<a \
href="mailto:noam@webkit.org">noam@webkit.org</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div>Following up on this.</div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div \
class="gmail_attr">FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak <<a \
href="mailto:mjs@apple.com" target="_blank">mjs@apple.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><br><div><br><blockquote type="cite"><div>On May \
11, 2020, at 9:53 PM, Noam Rosenthal <<a href="mailto:noam@webkit.org" \
target="_blank">noam@webkit.org</a>> wrote:</div><br><div><div dir="ltr"><div \
dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak <<a href="mailto:mjs@apple.com" \
target="_blank">mjs@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div><div><br></div>I noticed from comments in one \
of the Radars that the patch may result in an additional "fake paint", so it should \
probably be performance tested. Have you done any testing? \
</div></blockquote><div>I've tested it locally, I haven't noticed any \
significant side effect, because in complex situations the fake paint only happens \
once per page and bails early once contentfulness is detected. but I can run any \
additional test needed.<br> </div><blockquote class="gmail_quote" style="margin:0px \
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>We'll \
likely want to A/B some of Apple's page load speed \
benchmarks.</div></blockquote><div>A/B testing load speed sounds sensible. How do we \
go about doing that?<br></div></div></div></div></blockquote><br></div><div>Unfortunately \
our page load speed benchmarks are not public because they incorporate captured page \
content, which we can't freely \
redistribute.</div><div><br></div></blockquote></div></div></blockquote><div>So, can \
someone else from Apple review that the code is mature enough for this? Simon had \
reviewed the original patch. Maybe Zalan/Darin? <br><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div></div><div>A \
helpful person from Apple may be able to set up an A/B test for this \
patch.<br></div></blockquote></div></div></blockquote><div>What's required to ask \
for help from a helpful person at Apple? :) </div></div></div> \
_______________________________________________<br> webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" \
target="_blank">webkit-dev@lists.webkit.org</a><br> <a \
href="https://lists.webkit.org/mailman/listinfo/webkit-dev" rel="noreferrer" \
target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br> \
</blockquote></div>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic