[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Safari Tech Preview 96 available on wpt.fyi!
From:       Philip_Jägenstedt <foolip () chromium ! org>
Date:       2019-12-03 10:59:25
Message-ID: CAARdPYcg5ypF49893sgs2U2vAzKug3NcxpHse-CGLZqAG1LB6w () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tue, Dec 3, 2019 at 3:05 AM Jiewen Tan <jiewen_tan@apple.com> wrote:

> Hi Maciej,
> 
> On Dec 2, 2019, at 4:10 PM, Maciej Stachowiak <mjs@apple.com> wrote:
> 
> 
> There's a number of mysterious timeouts with 96. Not sure if flakiness or
> real?
> 
> The new WebCrypto failures are surprising, but likely real and should be
> investigated:
> https://wpt.fyi/results/WebCryptoAPI/wrapKey_unwrapKey?diff&filter=ADC&q=is%3Adifferent&run_id=347530011&run_id=381930013
>  <https://wpt.fyi/results/WebCryptoAPI/wrapKey_unwrapKey?diff&filter=ADC&q=is:different&run_id=347530011&run_id=381930013>
>  
> 
> I believe these tests are flaky. I have made a PR to improve it a while
> ago. I should probably get those improvement landed sometime.
> https://github.com/web-platform-tests/wpt/pull/6102
> 

That sounds very doable. I added you to the reviewers team to make this
easier and commented here:
https://github.com/web-platform-tests/wpt/pull/6102#issuecomment-561115470


[Attachment #5 (text/html)]

<div dir="ltr"><div dir="ltr">On Tue, Dec 3, 2019 at 3:05 AM Jiewen Tan &lt;<a \
href="mailto:jiewen_tan@apple.com">jiewen_tan@apple.com</a>&gt; wrote:<br></div><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: break-word;">Hi Maciej,<br><div><br><blockquote \
type="cite"><div>On Dec 2, 2019, at 4:10 PM, Maciej Stachowiak &lt;<a \
href="mailto:mjs@apple.com" target="_blank">mjs@apple.com</a>&gt; \
wrote:</div><br><div><div style="overflow-wrap: break-word;"><div><br></div>There's a \
number of mysterious timeouts with 96. Not sure if flakiness or \
real?<div><br></div><div>The new WebCrypto failures are surprising, but likely real \
and should be investigated:  <a \
href="https://wpt.fyi/results/WebCryptoAPI/wrapKey_unwrapKey?diff&amp;filter=ADC&amp;q=is:different&amp;run_id=347530011&amp;run_id=381930013" \
target="_blank">https://wpt.fyi/results/WebCryptoAPI/wrapKey_unwrapKey?diff&amp;filter \
=ADC&amp;q=is%3Adifferent&amp;run_id=347530011&amp;run_id=381930013</a></div></div></div></blockquote><div><br></div><div><span \
style="color:rgb(0,0,0)">I believe these tests are flaky. I have made a PR to improve \
it a while ago. I should probably get those improvement landed sometime.</span><div \
style="color:rgb(0,0,0)"><a \
href="https://github.com/web-platform-tests/wpt/pull/6102" \
target="_blank">https://github.com/web-platform-tests/wpt/pull/6102</a></div></div></div></div></blockquote><div><br></div><div>That \
sounds very doable. I added you to the reviewers team to make this easier and \
commented here:</div><div><a \
href="https://github.com/web-platform-tests/wpt/pull/6102#issuecomment-561115470">http \
s://github.com/web-platform-tests/wpt/pull/6102#issuecomment-561115470</a><br></div></div></div>




_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]