[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Breakpoints in #included .cpp files [Was: Growing tired of long build times? Check
From: Geoffrey Garen <ggaren () apple ! com>
Date: 2017-08-30 18:01:28
Message-ID: 9A545347-CC1C-4032-A46D-431C5F66D2EC () apple ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
"target.inline-breakpoint-strategy always" is also the workaround suggested in the \
bugs Simon cited.
Note that this setting is also necessary to fix a bunch of bugs with breakpoints in \
headers.
Geoff
> On Aug 29, 2017, at 11:03 PM, Rik Cabanier <cabanier@gmail.com> wrote:
>
>
>
> On Tue, Aug 29, 2017 at 8:48 PM, Simon Fraser <simon.fraser@apple.com \
> <mailto:simon.fraser@apple.com>> wrote:
> > On Aug 28, 2017, at 9:46 PM, Geoffrey Garen <ggaren@apple.com \
> > <mailto:ggaren@apple.com>> wrote:
> > > The line numbers and filenames will be total nonsense if we just concatenate \
> > > multiple source files together. But that's very easy to fix if the script that \
> > > concatenates the sources also adds a #line statement between "files" to change \
> > > the filename and reset the line number to 1. See \
> > > https://gcc.gnu.org/onlinedocs/cpp/Line-Control.html \
> > > <https://gcc.gnu.org/onlinedocs/cpp/Line-Control.html> (I suspect it will work \
> > > just fine for Clang as well).
> >
> > Our plan is to use #include. That has worked in the past.
>
> This should be tested before proceeding with the unified build plan. This has \
> certainly not always worked in the past (for Apple folks, see \
> rdar://problem/16751849 and rdar://problem/16829492, which is still open).
> Non-working breakpoints would be a show-stopper for many.
>
> Mozilla has been concatenating source files for a number of years. I don't remember \
> that they had to treat static specially but you did have to configure XCode so you \
> could set the breakpoints.
> See https://dxr.mozilla.org/mozilla-central/source/.lldbinit#17 \
> <https://dxr.mozilla.org/mozilla-central/source/.lldbinit#17>
>
[Attachment #5 (text/html)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space;" class="">"target.inline-breakpoint-strategy \
always" is also the workaround suggested in the bugs Simon cited.<div class=""><br \
class=""></div><div class="">Note that this setting is also necessary to fix a bunch \
of bugs with breakpoints in headers.<br class=""><div class=""><br \
class=""></div><div class="">Geoff</div><div class=""><br class=""><div><blockquote \
type="cite" class=""><div class="">On Aug 29, 2017, at 11:03 PM, Rik Cabanier <<a \
href="mailto:cabanier@gmail.com" class="">cabanier@gmail.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br \
class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Aug \
29, 2017 at 8:48 PM, Simon Fraser <span dir="ltr" class=""><<a \
href="mailto:simon.fraser@apple.com" target="_blank" \
class="">simon.fraser@apple.com</a>></span> wrote:<br class=""><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">> On Aug 28, 2017, at 9:46 PM, Geoffrey Garen \
<<a href="mailto:ggaren@apple.com" class="">ggaren@apple.com</a>> wrote:<br \
class=""> ><br class="">
>> The line numbers and filenames will be total nonsense if we just concatenate \
multiple source files together. But that's very easy to fix if the script that \
concatenates the sources also adds a #line statement between "files" to change the \
filename and reset the line number to 1. See <a \
href="https://gcc.gnu.org/onlinedocs/cpp/Line-Control.html" rel="noreferrer" \
target="_blank" class="">https://gcc.gnu.org/<wbr \
class="">onlinedocs/cpp/Line-Control.<wbr class="">html</a> (I suspect it will work \
just fine for Clang as well).<br class=""> ><br class="">
> Our plan is to use #include. That has worked in the past.<br class="">
<br class="">
This should be tested before proceeding with the unified build plan. This has \
certainly not always worked in the past (for Apple folks, see <a \
href="rdar://problem/16751849" class="">rdar://problem/16751849</a> and <a \
href="rdar://problem/16829492" class="">rdar://problem/16829492</a>, which is still \
open).<br class=""> <br class="">
Non-working breakpoints would be a show-stopper for many.<br \
class=""></blockquote><div class=""><br class=""></div><div class="">Mozilla has been \
concatenating source files for a number of years. I don't remember that they had to \
treat static specially but you did have to configure XCode so you could set the \
breakpoints.</div><div class=""><br class=""></div><div class="">See <a \
href="https://dxr.mozilla.org/mozilla-central/source/.lldbinit#17" \
class="">https://dxr.mozilla.org/mozilla-central/source/.lldbinit#17</a></div><div \
class=""><br class=""></div><div class=""> </div></div></div></div> \
</div></blockquote></div><br class=""></div></div></body></html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic