[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] JIT probe mechanism soon required for DFG and FTL OSR Exit
From: Mark Lam <mark.lam () apple ! com>
Date: 2017-08-10 22:29:44
Message-ID: CAA97F3F-0E2A-4F11-9765-C971945D0751 () apple ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Looks like I have to disable DFG for the Windows port as well. Relevant bugs:
https://bugs.webkit.org/show_bug.cgi?id=175447 \
<https://bugs.webkit.org/show_bug.cgi?id=175447> \
https://bugs.webkit.org/show_bug.cgi?id=175449 \
<https://bugs.webkit.org/show_bug.cgi?id=175449>
Mark
> On Aug 10, 2017, at 3:04 PM, Mark Lam <mark.lam@apple.com> wrote:
>
> FYI, following up on this work, I'll soon land patches that relies on the probe \
> mechanism being available. So, I will now make the JIT probe (MASM_PROBE) a \
> mandatory feature in order to enable the DFG and FTL (see \
> https://bugs.webkit.org/show_bug.cgi?id=175446 \
> <https://bugs.webkit.org/show_bug.cgi?id=175446>). As a consequence, I'll be \
> disabling the DFG for the MIPS port in this patch.
> Mark
>
> > On Jul 19, 2017, at 9:52 AM, Mark Lam <mark.lam@apple.com \
> > <mailto:mark.lam@apple.com>> wrote:
> >
> >
> > > On Jul 19, 2017, at 9:49 AM, Konstantin Tokarev <annulen@yandex.ru \
> > > <mailto:annulen@yandex.ru>> wrote:
> > >
> > >
> > > 19.07.2017, 02:49, "Mark Lam" <mark.lam@apple.com <mailto:mark.lam@apple.com>>:
> > > > FYI, I'm looking into making OSR exits work in a more memory efficient way \
> > > > using the JIT probe mechanism. Once we make this transition, the DFG and FTL \
> > > > will not work for any CPU targets that don't support the JIT probe mechanism. \
> > > > The API to the JIT probe will probably change as well as this work \
> > > > progresses. I'll take care of updating all the probe implementations for ARM \
> > > > and x86 variants.
> > > > AFAICT, only CPU(MIPS) does not currently support the probe mechanism. It's \
> > > > up to the MIPS folks to implement that support if they want to continue to \
> > > > use the DFG. Feel free to contact me if you have questions regarding the \
> > > > probe mechanism.
> > > > This work will be tracked in https://bugs.webkit.org/show_bug.cgi?id=174645 \
> > > > <https://bugs.webkit.org/show_bug.cgi?id=174645>.
> > >
> > > Could you elaborate, what code needs to be implemented for MIPS?
> >
> > See everything guarded by ENABLE(MASM_PROBE) in MacroAssemblerX86Common.cpp. \
> > You'll need to have the equivalent for MIPS. Eventually, we may need some \
> > additional changes as well, but that depends on the solution currently being \
> > investigated.
> > Mark
> >
> > >
> > > >
> > > > Thanks.
> > > >
> > > > Mark
> > > >
> > > > ,
> > > >
> > > > _______________________________________________
> > > > webkit-dev mailing list
> > > > webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
> > > > https://lists.webkit.org/mailman/listinfo/webkit-dev
> > >
> > >
> > > --
> > > Regards,
> > > Konstantin
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
> > https://lists.webkit.org/mailman/listinfo/webkit-dev \
> > <https://lists.webkit.org/mailman/listinfo/webkit-dev>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
[Attachment #5 (text/html)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class="">Looks like I have to disable DFG for the \
Windows port as well. Relevant bugs:<div class=""><a \
href="https://bugs.webkit.org/show_bug.cgi?id=175447" \
class="">https://bugs.webkit.org/show_bug.cgi?id=175447</a></div><div class=""><a \
href="https://bugs.webkit.org/show_bug.cgi?id=175449" \
class="">https://bugs.webkit.org/show_bug.cgi?id=175449</a></div><div class=""><br \
class=""></div><div class="">Mark<br class=""><div class=""><div class=""><div><br \
class=""><blockquote type="cite" class=""><div class="">On Aug 10, 2017, at 3:04 PM, \
Mark Lam <<a href="mailto:mark.lam@apple.com" class="">mark.lam@apple.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><div class=""><meta \
http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div \
style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: \
after-white-space;" class="">FYI, following up on this work, I'll soon land patches \
that relies on the probe mechanism being available. So, I will now make the JIT \
probe (MASM_PROBE) a mandatory feature in order to enable the DFG and FTL (see <a \
href="https://bugs.webkit.org/show_bug.cgi?id=175446" \
class="">https://bugs.webkit.org/show_bug.cgi?id=175446</a>). As a consequence, \
I'll be disabling the DFG for the MIPS port in this patch.<div class=""><br \
class=""></div><div class="">Mark<br class=""><div class=""><br class=""><blockquote \
type="cite" class=""><div class="">On Jul 19, 2017, at 9:52 AM, Mark Lam <<a \
href="mailto:mark.lam@apple.com" class="">mark.lam@apple.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><br style="font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px;" class="">On Jul 19, 2017, at 9:49 AM, Konstantin \
Tokarev <<a href="mailto:annulen@yandex.ru" class="">annulen@yandex.ru</a>> \
wrote:<br class=""><br class=""><br class=""><br class="">19.07.2017, 02:49, "Mark \
Lam" <<a href="mailto:mark.lam@apple.com" class="">mark.lam@apple.com</a>>:<br \
class=""><blockquote type="cite" class="">FYI, I'm looking into making OSR exits work \
in a more memory efficient way using the JIT probe mechanism. Once we make this \
transition, the DFG and FTL will not work for any CPU targets that don't support the \
JIT probe mechanism. The API to the JIT probe will probably change as well as \
this work progresses. I'll take care of updating all the probe implementations \
for ARM and x86 variants.<br class=""><br class="">AFAICT, only CPU(MIPS) does not \
currently support the probe mechanism. It's up to the MIPS folks to implement \
that support if they want to continue to use the DFG. Feel free to contact me \
if you have questions regarding the probe mechanism.<br class=""><br class="">This \
work will be tracked in <a href="https://bugs.webkit.org/show_bug.cgi?id=174645" \
class="">https://bugs.webkit.org/show_bug.cgi?id=174645</a>.<br \
class=""></blockquote><br class="">Could you elaborate, what code needs to be \
implemented for MIPS?<br class=""></blockquote><br style="font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" \
class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" \
class="">See everything guarded by ENABLE(MASM_PROBE) in MacroAssemblerX86Common.cpp. \
You'll need to have the equivalent for MIPS. Eventually, we may need some \
additional changes as well, but that depends on the solution currently being \
investigated.</span><br style="font-family: Helvetica; font-size: 12px; font-style: \
normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; \
text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; \
display: inline !important;" class="">Mark</span><br style="font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote type="cite" \
class=""><br class="">Thanks.<br class=""><br class="">Mark<br class=""><br \
class="">,<br class=""><br \
class="">_______________________________________________<br class="">webkit-dev \
mailing list<br class=""><a href="mailto:webkit-dev@lists.webkit.org" \
class="">webkit-dev@lists.webkit.org</a><br class=""><a \
href="https://lists.webkit.org/mailman/listinfo/webkit-dev" \
class="">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br \
class=""></blockquote><br class=""><br class="">--<span \
class="Apple-converted-space"> </span><br class="">Regards,<br \
class="">Konstantin<br class=""></blockquote><br style="font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" \
class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" \
class="">_______________________________________________</span><br \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; \
display: inline !important;" class="">webkit-dev mailing list</span><br \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px;" class=""><a \
href="mailto:webkit-dev@lists.webkit.org" style="font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; \
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" \
class="">webkit-dev@lists.webkit.org</a><br style="font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a \
href="https://lists.webkit.org/mailman/listinfo/webkit-dev" style="font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; \
text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" \
class="">https://lists.webkit.org/mailman/listinfo/webkit-dev</a></div></blockquote></div><br \
class=""></div></div>_______________________________________________<br \
class="">webkit-dev mailing list<br class=""><a \
href="mailto:webkit-dev@lists.webkit.org" class="">webkit-dev@lists.webkit.org</a><br \
class="">https://lists.webkit.org/mailman/listinfo/webkit-dev<br \
class=""></div></blockquote></div><br class=""></div></div></div></body></html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic