'[webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    [webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?
From:       Pascal Jacquemart <p.jacquemart () samsung ! com>
Date:       2014-10-14 10:25:58
Message-ID: 0B9A63A1581F0543B49498B36C88C838094D91D1 () ex1 ! seri ! co ! uk
[Download RAW message or body]

Hi,

I was wondering if we could remove the CUSTOM_PROTOCOLS compile guard?

I believe this is the default code path for all ports now since we moved EFL to use \
it last week https://bugs.webkit.org/show_bug.cgi?id=128177

At least, it is mandatory for GTK and EFL builds, I don't know much about other ports
I checked with EWS Bot that it won't break the build \
https://bugs.webkit.org/show_bug.cgi?id=128169 (first patch)

Also CUSTOM_PROTOCOLS can be confusing against another real feature called \
CUSTOM_SCHEME_HANDLER

Do you agree?

Pascal

[Attachment #3 (text/html)]

<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: \
10pt;">Hi,<br> <br>
I was wondering if we could remove the CUSTOM_PROTOCOLS compile guard?<br>
<br>
I believe this is the default code path for all ports now since we moved EFL to use \
it last week<br> https://bugs.webkit.org/show_bug.cgi?id=128177<br>
<br>
At least, it is mandatory for GTK and EFL builds, I don't know much about other \
ports<br> I checked with EWS Bot that it won't break the build <a \
href="https://bugs.webkit.org/show_bug.cgi?id=128169" target="_blank"> \
https://bugs.webkit.org/show_bug.cgi?id=128169</a> (first patch)<br> <br>
Also CUSTOM_PROTOCOLS can be confusing against another real feature called \
CUSTOM_SCHEME_HANDLER<br> <br>
Do you agree?<br>
<br>
Pascal<br>
</div>
</body>
</html>

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

--===============2373894827173174300==--

[prev in list] [next in list] [prev in thread] [next in thread] 