[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
From: Rik Cabanier <cabanier () gmail ! com>
Date: 2013-10-15 17:59:17
Message-ID: CAGN7qDCfu5FGY+XXiHvBxnV5ckYbmzgKMqJ=BBbmb8JHmjUP9Q () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Could you briefly say what you would like to see addressed?
On Tue, Oct 15, 2013 at 10:31 AM, Ryosuke Niwa <ryosuke.niwa@gmail.com>wrote:
> At this point, I don't think we should proceed with the implementation
> given the number of concerns other WebKit contributors have raised.
>
> Let's bring this discussion back to WebApps WG or WHATWG instead of
> spamming webkit-dev.
>
> - R. Niwa
>
> On Monday, October 14, 2013, Rik Cabanier wrote:
>>
>>
>> On Mon, Oct 14, 2013 at 4:13 PM, Timothy Hatcher <timothy@apple.com>wrote:
>>
>>> On Oct 14, 2013, at 3:44 PM, Rik Cabanier <cabanier@gmail.com> wrote:
>>>
>>> Isn't focus ring drawn on the canvas? If so, it's important that the
>>>>>>> focus ring fits within the canvas. e.g. consider focusing an element of
>>>>>>> 100px by 100px inside a canvas of the same size. If the focus ring were to
>>>>>>> be drawn around the element that currently has focus, then the entire focus
>>>>>>> ring would be drawn outside of the visible region.
>>>>>>>
>>>>>>
>>>>> True. That sounds like bad design though.
>>>>>
>>>>
>>>> Why? It doesn't seem particularly strange to have an element occupy the
>>>> entire canvas momentarily.
>>>>
>>>
>>> No, but I wouldn't never make the focus ring as large as the canvas.
>>>
>>>
>>> Even if you don't make it full size, if the focus ring is drawn into the
>>> canvas buffer, you don't know how much room you need to account for. (If
>>> the focused control is near the edge of the canvas.)
>>>
>>
>> The spec says:
>>
>> draw a focus ring of the appropriate style along the intended path,
>> following platform conventions.
>>
>>
>> In one of the email threads I have asked what "along the path" meant but
>> there hasn't been an answer...
>> I think it's assumed that you leave enough space so the ring fits. There
>> isn't even anything in the spec that says that the path should fall in the
>> canvas region.
>>
>>
>
> --
> Ryosuke Niwa
>
>
>
[Attachment #5 (text/html)]
<div dir="ltr">Could you briefly say what you would like to see \
addressed?<div><br></div></div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Tue, Oct 15, 2013 at 10:31 AM, Ryosuke Niwa <span \
dir="ltr"><<a href="mailto:ryosuke.niwa@gmail.com" \
target="_blank">ryosuke.niwa@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">At this point, I don't think we should proceed with the \
implementation given the number of concerns other WebKit contributors have \
raised.<div> <br></div><div>Let's bring this discussion back to WebApps WG or \
WHATWG instead of spamming webkit-dev.<span></span><br> <div><div><br></div><div>- R. \
Niwa</div><div><div class="h5"><div><br>On Monday, October 14, 2013, Rik Cabanier \
wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div dir="ltr"><div class="gmail_extra">
<br><div class="gmail_quote">On Mon, Oct 14, 2013 at 4:13 PM, Timothy Hatcher <span \
dir="ltr"><<a>timothy@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
style="word-wrap:break-word"><div>On Oct 14, 2013, at 3:44 PM, Rik Cabanier \
<<a>cabanier@gmail.com</a>> wrote:<br>
<div><br><blockquote type="cite"><blockquote class="gmail_quote" \
style="font-family:Verdana;font-size:11px;font-style:normal;font-variant:normal;font-w \
eight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;margin:0px \
0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Isn't focus ring \
drawn on the canvas? If so, it's important that the focus ring fits within the \
canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the \
same size. If the focus ring were to be drawn around the element that currently has \
focus, then the entire focus ring would be drawn outside of the visible region.</div>
</div></div></blockquote></div></div></div></blockquote><div><br></div></div><div>True. \
That sounds like bad design \
though.</div></div></div></div></blockquote><div><br></div></div><div>Why? It \
doesn't seem particularly strange to have an element occupy the entire canvas \
momentarily.</div>
</div></div></div></blockquote><div \
style="font-family:Verdana;font-size:11px;font-style:normal;font-variant:normal;font-w \
eight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<br></div><div style="font-family:Verdana;font-size:11px;font-style:normal;font-varian \
t:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
No, but I wouldn't never make the focus ring as large as the \
canvas.</div></blockquote><br></div></div><div>Even if you don't make it full \
size, if the focus ring is drawn into the canvas buffer, you don't know how much \
room you need to account for. (If the focused control is near the edge of the \
canvas.)</div>
</div></blockquote><div><br></div><div>The spec says:</div></div></div><blockquote \
style="margin:0 0 0 40px;border:none;padding:0px"><div class="gmail_extra"><div \
class="gmail_quote">draw a focus ring of the appropriate style along the intended \
path, following platform conventions.</div>
</div></blockquote><div class="gmail_extra"><div class="gmail_quote"><br></div><div \
class="gmail_quote">In one of the email threads I have asked what "along the \
path" meant but there hasn't been an answer...</div>
<div class="gmail_quote">I think it's assumed that you leave enough space so the \
ring fits. There isn't even anything in the spec that says that the path should \
fall in the canvas region.</div><br></div></div> \
</blockquote></div></div></div></div></div><span class="HOEnZb"><font \
color="#888888"><br><br>-- <br><div>Ryosuke Niwa</div><div><br></div><br> \
</font></span></blockquote></div><br></div>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic