[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] webkit-patch and clearing flags
From:       Antonio Gomes <tonikitoo () webkit ! org>
Date:       2013-05-30 2:48:25
Message-ID: CAANoYzM21=Up0TeSxYrbz9+ZVs5Jm9pgYhcTF=__rQcX3pdH=w () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I found it very useful while reviewing to look at a bug and see what a
patch has been r-'ed before. Even if it has been marked as obsolete by a
follow up patch.

It is a valuable quick reference of the patch/bug/work history.


On Wed, May 29, 2013 at 12:21 PM, Bem Jones-Bey <bjonesbe@adobe.com> wrote:

> Hey WebKit,
>
> Would it be reasonable for webkit-patch to not clear flags on an
> attachement when it obsoletes it if there's an r+? Maybe it doesn't
> actually matter (i.e. I know I can still commit the patch), but it bothers
> me when it clears away an r+ because I forgot to tell it --no-obsolete when
> I'm updating a patch for nits.
>
> - Bem
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>

[Attachment #5 (text/html)]

<div dir="ltr">I found it very useful while reviewing to look at a bug and see what a \
patch has been r-&#39;ed before. Even if it has been marked as obsolete by a follow \
up patch.<div><br></div><div>It is a valuable quick reference of the patch/bug/work \
history.</div>

</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 29, 2013 \
at 12:21 PM, Bem Jones-Bey <span dir="ltr">&lt;<a href="mailto:bjonesbe@adobe.com" \
target="_blank">bjonesbe@adobe.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hey WebKit,<br> <br>
Would it be reasonable for webkit-patch to not clear flags on an attachement when it \
obsoletes it if there&#39;s an r+? Maybe it doesn&#39;t actually matter (i.e. I know \
I can still commit the patch), but it bothers me when it clears away an r+ because I \
forgot to tell it --no-obsolete when I&#39;m updating a patch for nits.<br>


<br>
- Bem<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" \
target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br> \
</blockquote></div><br></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]