[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] How to deal with the difference between JS IDL and V8 IDL?
From: xuewen <xuewen.wang () torchmobile ! com ! cn>
Date: 2012-04-23 8:46:52
Message-ID: 4F9516FC.9000601 () torchmobile ! com ! cn
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I looked the patch, they should be the same issue. I will help to verify
the patch
Thanks
Sean Wang
On 04/23/2012 04:14 PM, Ryosuke Niwa wrote:
> I think this is caused by the same cause as
> https://bugs.webkit.org/show_bug.cgi?id=84540.
>
> On Mon, Apr 23, 2012 at 12:48 AM, Kentaro Hara <haraken@chromium.org
> <mailto:haraken@chromium.org>> wrote:
>
> > Are the IDL generators for JS and V8 same?
>
> Different. WebCore/bindings/scripts/CodeGeneratorJS.pm for JSC, and
> WebCore/bindings/scripts/CodeGeneratorV8.pm for V8. Though we are
> trying hard to make those two behaviors same:)
>
> > The array syntax "float[]" is not supported by the JS binding
> IDL generator.
>
> This would be a bug. I think JSC should also support it. Would you
> file a bug to https://bugs.webkit.org/enter_bug.cgi?product=WebKit?
>
>
> On Mon, Apr 23, 2012 at 12:40 AM, xuewen
> <xuewen.wang@torchmobile.com.cn
> <mailto:xuewen.wang@torchmobile.com.cn>> wrote:
> > In the file Source/WebCore/Modules/gamepad/Gamepad.idl, there
> are two
> > definitions:
> >
> > readonly attribute float[] axes;
> > readonly attribute float[] buttons;
> >
> > The array syntax "float[]" is not supported by the JS binding
> IDL generator.
> > Are the IDL generators for JS and V8 same?
> > If it is right for V8, how do we deal with this difference
> between JS
> > binding and V8 binding?
> >
> > Thanks
> > Sean Wang
> >
> >
> >
> ---------------------------------------------------------------------
> > This transmission (including any attachments) may contain
> confidential
> > information, privileged material (including material protected
> by the
> > solicitor-client or other applicable privileges), or constitute
> non-public
> > information. Any use of this information by anyone other than
> the intended
> > recipient is prohibited. If you have received this transmission
> in error,
> > please immediately reply to the sender and delete this
> information from your
> > system. Use, dissemination, distribution, or reproduction of this
> > transmission by unintended recipients is not authorized and may
> be unlawful.
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
> --
> Kentaro Hara, Tokyo, Japan (http://haraken.info)
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, \
privileged material (including material protected by the solicitor-client or other \
applicable privileges), or constitute non-public information. Any use of this \
information by anyone other than the intended recipient is prohibited. If you have \
received this transmission in error, please immediately reply to the sender and \
delete this information from your system. Use, dissemination, distribution, or \
reproduction of this transmission by unintended recipients is not authorized and may \
be unlawful.
[Attachment #5 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I looked the patch, they should be the same issue. I will help to
verify the patch<br>
<br>
Thanks<br>
Sean Wang<br>
<br>
On 04/23/2012 04:14 PM, Ryosuke Niwa wrote:
<blockquote
cite="mid:CABNRm63DSoGEbUPteqVmF7Wq2n0ERn5A5x8Bm5Q+oUT7Gxdu4w@mail.gmail.com"
type="cite">
<div class="gmail_extra">I think this is caused by the same cause
as <a moz-do-not-send="true"
href="https://bugs.webkit.org/show_bug.cgi?id=84540">https://bugs.webkit.org/show_bug.cgi?id=84540</a>.<br>
<br>
<div class="gmail_quote">On Mon, Apr 23, 2012 at 12:48 AM,
Kentaro Hara <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:haraken@chromium.org" \
target="_blank">haraken@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">> Are the IDL generators for JS and V8
same?<br>
<br>
</div>
Different. WebCore/bindings/scripts/CodeGeneratorJS.pm for
JSC, and<br>
WebCore/bindings/scripts/CodeGeneratorV8.pm for V8. Though
we are<br>
trying hard to make those two behaviors same:)<br>
<div class="im"><br>
> The array syntax "float[]" is not supported by the JS
binding IDL generator.<br>
<br>
</div>
This would be a bug. I think JSC should also support it.
Would you<br>
file a bug to <a moz-do-not-send="true"
href="https://bugs.webkit.org/enter_bug.cgi?product=WebKit"
target="_blank">https://bugs.webkit.org/enter_bug.cgi?product=WebKit</a>?<br>
<div class="HOEnZb">
<div class="h5"><br>
<br>
On Mon, Apr 23, 2012 at 12:40 AM, xuewen <<a
moz-do-not-send="true"
href="mailto:xuewen.wang@torchmobile.com.cn">xuewen.wang@torchmobile.com.cn</a>>
wrote:<br>
> In the file
Source/WebCore/Modules/gamepad/Gamepad.idl, there are
two<br>
> definitions:<br>
><br>
> readonly attribute float[] axes;<br>
> readonly attribute float[] buttons;<br>
><br>
> The array syntax "float[]" is not supported by the
JS binding IDL generator.<br>
> Are the IDL generators for JS and V8 same?<br>
> If it is right for V8, how do we deal with this
difference between JS<br>
> binding and V8 binding?<br>
><br>
> Thanks<br>
> Sean Wang<br>
><br>
><br>
>
---------------------------------------------------------------------<br>
> This transmission (including any attachments) may
contain confidential<br>
> information, privileged material (including
material protected by the<br>
> solicitor-client or other applicable privileges),
or constitute non-public<br>
> information. Any use of this information by anyone
other than the intended<br>
> recipient is prohibited. If you have received this
transmission in error,<br>
> please immediately reply to the sender and delete
this information from your<br>
> system. Use, dissemination, distribution, or
reproduction of this<br>
> transmission by unintended recipients is not
authorized and may be unlawful.<br>
> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a moz-do-not-send="true"
href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
> <a moz-do-not-send="true"
href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev"
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br>
<br>
<br>
</div>
</div>
<span class="HOEnZb"><font color="#888888">--<br>
Kentaro Hara, Tokyo, Japan (<a moz-do-not-send="true"
href="http://haraken.info" \
target="_blank">http://haraken.info</a>)<br> </font></span>
<div class="HOEnZb">
<div class="h5">_______________________________________________<br>
webkit-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a moz-do-not-send="true"
href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev"
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
--------------------------------------------------------------------- <br>
This transmission (including any attachments) may contain confidential information, \
privileged material (including material protected by the solicitor-client or other \
applicable privileges), or constitute non-public information. Any use of this \
information by anyone other than the intended recipient is prohibited. If you have \
received this transmission in error, please immediately reply to the sender and \
delete this information from your system. Use, dissemination, distribution, or \
reproduction of this transmission by unintended recipients is not authorized and may \
be unlawful. </body>
</html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic