[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] NRWT Migration Update
From: SravanKumar Sandela <sravan.ken () gmail ! com>
Date: 2011-10-22 3:54:00
Message-ID: CAHOEsKPiy_syCJieDu+KvfjyrNso8KywZoL8+-bEzecpaUTw0A () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Eric and Roben,
Thanks a lot for the description and link.
-Sravan
On Fri, Oct 21, 2011 at 10:59 PM, Eric Seidel <eric@webkit.org> wrote:
> I didn't even know that page existed. :)
>
> NRWT is Python. It's split into many files. It is part of webkitpy
> (which is our python library for dealing with webkit).
>
> NRWT was written independently (over several years) at Google. It
> predates webkitpy, but it now lives as part of webkitpy:
> http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests
> but it doesn't fit 100% into the webkitpy model (it's not a Command
> subclass, it doesn't have a Host object) so hacking on it can be
> slightly confusing.
>
> As a port author the files of most interest to you are likely the Port
> subclasses:
>
> http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port
> qt.py<http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port%0Aqt.py>,
> gtk.py, etc.
>
> I'm happy to answer any and all questions as they come up.
>
>
> http://trac.webkit.org/browser/trunk/Tools/Scripts/run-webkit-tests
> is still the preferred way to run the tests. Eventually that wrapper
> will be deleted and replaced with NRWT directly. Until then, it is
> smart enough to run ORWT vs NRWT depending on the platform and
> configuration.
>
> Also, although NRWT supports running tests in parallel, we have that
> feature disabled by default when run from run-webkit-tests. Running
> tests in parallel can cause some tests to flake. If you're developing
> on your local machine and don't care about possible flakes, just want
> the fastest test run possible, it's best to run new-run-webkit-tests
> directly for now.
>
> -eric
>
>
> On Fri, Oct 21, 2011 at 6:41 AM, SravanKumar Sandela
> <sravan.ken@gmail.com> wrote:
> > Hi Eric,
> >
> > Can you please inform us, what are the major difference between NRWT and
> > ORWT. I think it would of lot help for people like me who worked on ORWT
> > long back and now to catch up with NRWT.
> >
> > Thanks a lot in anticipation.
> >
> > -Sravan.
> >
> > On Fri, Oct 21, 2011 at 5:03 PM, Eric Seidel <eric@webkit.org> wrote:
> > >
> > > The WK2 bot looks stable (possibly more stable than before) after the
> > > NRWT switchover:
> > >
> > >
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r9 \
> 8091%20(15558)/results.html<http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r98091%20%2815558%29/results.html>
>
> > >
> > > I'll work on switching the --leaks bot back to NRWT next week, and
> > > then the only remaining builder to switch is Apple's Windows. (I
> > > likely won't be able to takle that one myself.)
> > >
> > > Thanks again for your patience in this process.
> > >
> > > -eric
> > >
> > > On Thu, Oct 20, 2011 at 9:54 PM, Eric Seidel <eric@webkit.org> wrote:
> > > > After further testing tonight, I was able to reproduce the exact set
> > > > of 81 WebKit 2 failures with both NRWT and ORWT this evening. I'm
> > > > going to move the bots to NRWT shortly.
> > > >
> > > > -eric
> > > >
> > > > On Wed, Oct 19, 2011 at 9:59 PM, Eric Seidel <eric@webkit.org> wrote:
> > > > > After a long hiatus, I'm back working on NRWT.
> > > > >
> > > > > As of this evening all of the blocking issues to switching the WK2
> bot
> > > > > are resolved:
> > > > > https://bugs.webkit.org/show_bug.cgi?id=56729
> > > > >
> > > > > Just waiting for the WK2 bot to have some smaller number of failures,
> > > > > then I'll pull the trigger.
> > > > >
> > > > >
> > > > > After WK2 is switched to NRWT, there is only --leaks and Windows to
> > > > > switch, before we can consider deleting ORWT.
> > > > >
> > > > > Interested parties can continue to track the NRWT migration here:
> > > > > https://bugs.webkit.org/show_bug.cgi?id=34984
> > > > >
> > > > > -eric
> > > > >
> > > >
> > > _______________________________________________
> > > webkit-dev mailing list
> > > webkit-dev@lists.webkit.org
> > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> >
> >
> > --
> > Living for the unseen and undone....
> >
>
--
Living for the unseen and undone....
[Attachment #5 (text/html)]
Hi Eric and Roben,<br><br>Thanks a lot for the description and \
link.<br><br>-Sravan<br><br><div class="gmail_quote">On Fri, Oct 21, 2011 at 10:59 \
PM, Eric Seidel <span dir="ltr"><<a \
href="mailto:eric@webkit.org">eric@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;">I didn't even know that page existed. :)<br> <br>
NRWT is Python. It's split into many files. It is part of webkitpy<br>
(which is our python library for dealing with webkit).<br>
<br>
NRWT was written independently (over several years) at Google. It<br>
predates webkitpy, but it now lives as part of webkitpy:<br>
<a href="http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests" \
target="_blank">http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests</a><br>
but it doesn't fit 100% into the webkitpy model (it's not a Command<br>
subclass, it doesn't have a Host object) so hacking on it can be<br>
slightly confusing.<br>
<br>
As a port author the files of most interest to you are likely the Port<br>
subclasses:<br>
<a href="http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port%0Aqt.py" \
target="_blank">http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port<br>
qt.py</a>, gtk.py, etc.<br>
<br>
I'm happy to answer any and all questions as they come up.<br>
<br>
<br>
<a href="http://trac.webkit.org/browser/trunk/Tools/Scripts/run-webkit-tests" \
target="_blank">http://trac.webkit.org/browser/trunk/Tools/Scripts/run-webkit-tests</a><br>
is still the preferred way to run the tests. Eventually that wrapper<br>
will be deleted and replaced with NRWT directly. Until then, it is<br>
smart enough to run ORWT vs NRWT depending on the platform and<br>
configuration.<br>
<br>
Also, although NRWT supports running tests in parallel, we have that<br>
feature disabled by default when run from run-webkit-tests. Running<br>
tests in parallel can cause some tests to flake. If you're developing<br>
on your local machine and don't care about possible flakes, just want<br>
the fastest test run possible, it's best to run new-run-webkit-tests<br>
directly for now.<br>
<font color="#888888"><br>
-eric<br>
</font><div><div></div><div class="h5"><br>
<br>
On Fri, Oct 21, 2011 at 6:41 AM, SravanKumar Sandela<br>
<<a href="mailto:sravan.ken@gmail.com">sravan.ken@gmail.com</a>> wrote:<br>
> Hi Eric,<br>
><br>
> Can you please inform us, what are the major difference between NRWT and<br>
> ORWT. I think it would of lot help for people like me who worked on ORWT<br>
> long back and now to catch up with NRWT.<br>
><br>
> Thanks a lot in anticipation.<br>
><br>
> -Sravan.<br>
><br>
> On Fri, Oct 21, 2011 at 5:03 PM, Eric Seidel <<a \
href="mailto:eric@webkit.org">eric@webkit.org</a>> wrote:<br> >><br>
>> The WK2 bot looks stable (possibly more stable than before) after the<br>
>> NRWT switchover:<br>
>><br>
>> <a href="http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r98091%20%2815558%29/results.html" \
target="_blank">http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98091%20(15558)/results.html</a><br>
>><br>
>> I'll work on switching the --leaks bot back to NRWT next week, and<br>
>> then the only remaining builder to switch is Apple's Windows. (I<br>
>> likely won't be able to takle that one myself.)<br>
>><br>
>> Thanks again for your patience in this process.<br>
>><br>
>> -eric<br>
>><br>
>> On Thu, Oct 20, 2011 at 9:54 PM, Eric Seidel <<a \
href="mailto:eric@webkit.org">eric@webkit.org</a>> wrote:<br> >> > After \
further testing tonight, I was able to reproduce the exact set<br> >> > of \
81 WebKit 2 failures with both NRWT and ORWT this evening. I'm<br> >> > \
going to move the bots to NRWT shortly.<br> >> ><br>
>> > -eric<br>
>> ><br>
>> > On Wed, Oct 19, 2011 at 9:59 PM, Eric Seidel <<a \
href="mailto:eric@webkit.org">eric@webkit.org</a>> wrote:<br> >> >> \
After a long hiatus, I'm back working on NRWT.<br> >> >><br>
>> >> As of this evening all of the blocking issues to switching the WK2 \
bot<br> >> >> are resolved:<br>
>> >> <a href="https://bugs.webkit.org/show_bug.cgi?id=56729" \
target="_blank">https://bugs.webkit.org/show_bug.cgi?id=56729</a><br> >> \
>><br> >> >> Just waiting for the WK2 bot to have some smaller \
number of failures,<br> >> >> then I'll pull the trigger.<br>
>> >><br>
>> >><br>
>> >> After WK2 is switched to NRWT, there is only --leaks and Windows \
to<br> >> >> switch, before we can consider deleting ORWT.<br>
>> >><br>
>> >> Interested parties can continue to track the NRWT migration \
here:<br> >> >> <a href="https://bugs.webkit.org/show_bug.cgi?id=34984" \
target="_blank">https://bugs.webkit.org/show_bug.cgi?id=34984</a><br> >> \
>><br> >> >> -eric<br>
>> >><br>
>> ><br>
>> _______________________________________________<br>
>> webkit-dev mailing list<br>
>> <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
>> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" \
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br> \
><br> ><br>
><br>
> --<br>
> Living for the unseen and undone....<br>
><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Living for the unseen \
and undone....<br>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic