[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] reminder: don't do blanket style fixups
From:       David Levin <levin () chromium ! org>
Date:       2011-10-20 2:19:56
Message-ID: CACmjMJSms-bvHWdO6gPrP+SVQhq8S5O-uBm_vjMvMAeSipBUCQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Trailing whitespace guidelines aren't part of the WebKit style guide on
purpose.

Thus, it wasn't a style clean-up, so I guess that would make it a change to
fit someone's preference.

dave

On Wed, Oct 19, 2011 at 6:38 PM, Ojan Vafai <ojan@chromium.org> wrote:

> I saw a patch get committed recently that just fixes trailing whitespace
> across a large swath of the codebase.
>
> In general, we prefer that pure style cleanups are only done as a precursor
> to actually modifying the code. Otherwise, while they serve to make the
> style consistent, they also make it considerably harder to dig through the
> commit history for a given chunk of code.
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>

[Attachment #5 (text/html)]

Trailing whitespace guidelines aren&#39;t part of the WebKit style guide on \
purpose.<div><br></div><div>Thus, it wasn&#39;t a style clean-up, so I guess that \
would make it a change to fit someone&#39;s preference.<div><div>

<div><br><div><div><div>dave</div><div><br></div><div><div class="gmail_quote">On \
Wed, Oct 19, 2011 at 6:38 PM, Ojan Vafai <span dir="ltr">&lt;<a \
href="mailto:ojan@chromium.org">ojan@chromium.org</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"><div><span style="background-color:transparent">I saw a \
patch get committed recently that just fixes trailing whitespace across a large swath \
of the codebase.</span></div>

<div><span style="background-color:transparent"><br>

</span></div><div><span style="background-color:transparent">In general, we prefer \
that pure style cleanups are only done as a precursor to actually modifying the code. \
Otherwise, while they serve to make the style consistent, they also make it \
considerably harder to dig through the commit history for a given chunk of \
code.</span></div>



<br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" \
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br> \
<br></blockquote></div><br></div></div></div></div></div></div></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]