[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Misplaced files
From: Jeremy Orlow <jorlow () chromium ! org>
Date: 2010-08-31 17:07:45
Message-ID: AANLkTi=9T18br1GA6fJSvTk3EwN-kR-i2jPu9XJHcmkF () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Aug 31, 2010 at 5:57 PM, Yaar Schnitman <yaar@chromium.org> wrote:
> No, the file names. The module part matters when IDLs refer to each other
> (typedefs and includes) - but these are easy to fix.
Can you give an example of what you're talking about? I can't remember
seeing anything like this in the past.
Also, is there a reason why they're necessary?
> On Tue, Aug 31, 2010 at 9:00 AM, Jeremy Orlow <jorlow@chromium.org> wrote:
>
>> You're talking about the "module" part of the IDL? Is that even used by
>> anything or specified anywhere? As far as I can tell, the answer is no.
>>
>>
>> On Tue, Aug 31, 2010 at 4:54 PM, Yaar Schnitman <yaar@chromium.org>wrote:
>>
>>> Regarding renaming files: The .cpp and .h file names need to correspond
>>> with .idl names, which in turn correspond with the interfaces specified in
>>> these .idl. The later are standard, user-facing strings.
>>
>>
Sure... but the _directories_ are not user facing. That's all we're
talking about here.
> This means that you can't change them without fixing a lot of generation
>>> and build rules. If your goal is reducing complexity, this might not be a
>>> good idea.
>>>
>>> On Tue, Aug 31, 2010 at 3:02 AM, Jeremy Orlow <jorlow@chromium.org>wrote:
>>>
>>>> On Mon, Aug 30, 2010 at 5:17 PM, Darin Fisher <darin@chromium.org>wrote:
>>>>
>>>>> On Mon, Aug 30, 2010 at 9:11 AM, Maciej Stachowiak <mjs@apple.com>wrote:
>>>>>
>>>>>>
>>>>>> On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote:
>>>>>>
>>>>>> On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth <abarth@webkit.org>wrote:
>>>>>>
>>>>>>> On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak <mjs@apple.com>
>>>>>>> wrote:
>>>>>>> > Yes. The file-related stuff should all be in one directory, I
>>>>>>> think.
>>>>>>>
>>>>>>> Ok. I moved the files from WebCore/html to WebCore/fileapi.
>>>>>>>
>>>>>>> On Aug 27, 2010, at 6:19 PM, Kinuko Yasuda wrote:
>>>>>>> > We have bunch of FileSystem (which is a part of File API) related
>>>>>>> files in
>>>>>>> > WebCore/storage/.
>>>>>>> > Maybe we should move them to the new directory too?
>>>>>>>
>>>>>>> Are these the files you're talking about?
>>>>>>>
>>>>>>> WebCore/storage/DOMFilePath.cpp
>>>>>>> WebCore/storage/DOMFilePath.h
>>>>>>> WebCore/storage/DOMFileSystem.cpp
>>>>>>> WebCore/storage/DOMFileSystem.h
>>>>>>> WebCore/storage/DOMFileSystem.idl
>>>>>>> WebCore/storage/FileEntry.cpp
>>>>>>> WebCore/storage/FileEntry.h
>>>>>>> WebCore/storage/FileEntry.idl
>>>>>>> WebCore/storage/FileSystemCallback.h
>>>>>>> WebCore/storage/FileSystemCallback.idl
>>>>>>> WebCore/storage/FileSystemCallbacks.cpp
>>>>>>> WebCore/storage/FileSystemCallbacks.h
>>>>>>> WebCore/storage/LocalFileSystem.cpp
>>>>>>> WebCore/storage/LocalFileSystem.h
>>>>>>>
>>>>>>> I'm happy to move them to WebCore/fileapi, but I'm also happy for you
>>>>>>> to do it.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Adam
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> How about just moving everything into WebCore/storage? This is all
>>>>>> storage-related stuff.
>>>>>>
>>>>>>
>>>>>> I think the File API is large enough to deserve its own directory. In
>>>>>> fact, it might be worth splitting up the remaining contents of the storage
>>>>>> directory too. It is confusing to have large but almost entirely separate
>>>>>> APIs all piled into one directory. It is true they are all
>>>>>> "storage-related", but that is a pretty broad theme, and LocalStorage, SQL
>>>>>> Storage, Indexed DB and File API have little or no interaction with each
>>>>>> other.
>>>>>>
>>>>>> Regards,
>>>>>> Maciej
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> That's fair. Plus, there are a lot of files in there already.
>>>>>
>>>>
>>>> What names should we use?
>>>>
>>>> WebSQLDatabase:
>>>> Like WebSockets, I think the "web" part is pretty important to keep
>>>> people from getting confused. 'websqldatabase' seems a bit long though.
>>>> 'websqldb' maybe?
>>>>
>>>> WebStorage:
>>>> Currently we call this "Dom Storage" throughout the codebase (including
>>>> in the ENABLE macro), so we may want to call it "domstorage". Like
>>>> WebSockets and WebSQLDatabase, I think "storage" with no prefix seems like a
>>>> generic storage directory so we should probably call it "webstorage" if
>>>> "domstorage" isn't acceptable.
>>>>
>>>> Indexed Database API:
>>>> "IndexedDB" is what it's commonly called, so a directory of "indexeddb"
>>>> seems like the way to go.
>>>>
>>>> J
>>>>
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev@lists.webkit.org
>>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>>
>>>>
>>>
>>
>
[Attachment #5 (text/html)]
<div class="gmail_quote">On Tue, Aug 31, 2010 at 5:57 PM, Yaar Schnitman <span \
dir="ltr"><<a href="mailto:yaar@chromium.org">yaar@chromium.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">
No, the file names. The module part matters when IDLs refer to each other (typedefs \
and includes) - but these are easy to fix.</blockquote><div><br></div><div>Can you \
give an example of what you're talking about? I can't remember seeing \
anything like this in the past.</div>
<div><br></div><div>Also, is there a reason why they're necessary?</div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"><div><div class="h5"><div class="gmail_quote">
On Tue, Aug 31, 2010 at 9:00 AM, Jeremy Orlow <span dir="ltr"><<a \
href="mailto:jorlow@chromium.org" target="_blank">jorlow@chromium.org</a>></span> \
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">You're talking about the "module" part of the \
IDL? Is that even used by anything or specified anywhere? As far as I can tell, the \
answer is no.<div>
<div></div><div><br><br><div class="gmail_quote">On Tue, Aug 31, 2010 at 4:54 PM, \
Yaar Schnitman <span dir="ltr"><<a href="mailto:yaar@chromium.org" \
target="_blank">yaar@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Regarding renaming files: The .cpp and .h file names need to \
correspond with .idl names, which in turn correspond with the interfaces specified in \
these .idl. The later are standard, user-facing strings.</blockquote>
</div></div></div></blockquote></div></div></div></blockquote><div><br></div><div>Sure... \
but the _directories_ are not user facing. That's all we're talking about \
here.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div class="h5"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
This means that you can't change them without fixing a lot of generation and \
build rules. If your goal is reducing complexity, this might not be a good idea.<br>
<br><div class="gmail_quote"><div><div></div><div>On Tue, Aug 31, 2010 at 3:02 AM, \
Jeremy Orlow <span dir="ltr"><<a href="mailto:jorlow@chromium.org" \
target="_blank">jorlow@chromium.org</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div><div></div><div>
<div class="gmail_quote"><div><div></div><div>On Mon, Aug 30, 2010 at 5:17 PM, Darin \
Fisher <span dir="ltr"><<a href="mailto:darin@chromium.org" \
target="_blank">darin@chromium.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div><div></div><div><div class="gmail_quote">On Mon, Aug 30, 2010 at 9:11 AM, Maciej \
Stachowiak <span dir="ltr"><<a href="mailto:mjs@apple.com" \
target="_blank">mjs@apple.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><div></div><div><br><div><div>On Aug 30, 2010, \
at 8:36 AM, Darin Fisher wrote:</div><br><blockquote type="cite"><div \
class="gmail_quote">On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth <span \
dir="ltr"><<a href="mailto:abarth@webkit.org" \
target="_blank">abarth@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div>On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak \
<<a href="mailto:mjs@apple.com" target="_blank">mjs@apple.com</a>> wrote:<br> \
> Yes. The file-related stuff should all be in one directory, I think.<br> <br>
</div>Ok. I moved the files from WebCore/html to WebCore/fileapi.<br>
<div><br>
On Aug 27, 2010, at 6:19 PM, Kinuko Yasuda wrote:<br>
> We have bunch of FileSystem (which is a part of File API) related files in<br>
> WebCore/storage/.<br>
> Maybe we should move them to the new directory too?<br>
<br>
</div>Are these the files you're talking about?<br>
<br>
WebCore/storage/DOMFilePath.cpp<br>
WebCore/storage/DOMFilePath.h<br>
WebCore/storage/DOMFileSystem.cpp<br>
WebCore/storage/DOMFileSystem.h<br>
WebCore/storage/DOMFileSystem.idl<br>
WebCore/storage/FileEntry.cpp<br>
WebCore/storage/FileEntry.h<br>
WebCore/storage/FileEntry.idl<br>
WebCore/storage/FileSystemCallback.h<br>
WebCore/storage/FileSystemCallback.idl<br>
WebCore/storage/FileSystemCallbacks.cpp<br>
WebCore/storage/FileSystemCallbacks.h<br>
WebCore/storage/LocalFileSystem.cpp<br>
WebCore/storage/LocalFileSystem.h<br>
<br>
I'm happy to move them to WebCore/fileapi, but I'm also happy for you to do \
it.<br> <br>
Thanks,<br>
<font color="#888888">Adam<br>
</font><div><div></div><div><br></div></div></blockquote><div><br></div><div><br></div><div>How \
about just moving everything into WebCore/storage? This is all storage-related \
stuff.</div></div></blockquote><br></div></div>
</div><div>I think the File API is large enough to deserve its own directory. In \
fact, it might be worth splitting up the remaining contents of the storage directory \
too. It is confusing to have large but almost entirely separate APIs all piled into \
one directory. It is true they are all "storage-related", but that is a \
pretty broad theme, and LocalStorage, SQL Storage, Indexed DB and File API have \
little or no interaction with each other.</div>
<div><br></div><div>Regards,</div><div>Maciej</div><div><br></div><div><br></div><br></div>
</blockquote></div><br></div></div><div>That's fair. Plus, there are a lot of \
files in there already.</div></blockquote><div><br></div></div></div><div>What names \
should we use?</div><div><br></div><div>WebSQLDatabase:</div>
<div>
Like WebSockets, I think the "web" part is pretty important to keep people \
from getting confused. 'websqldatabase' seems a bit long though. \
'websqldb' maybe?</div><div><br></div><div>WebStorage:</div>
<div>Currently we call this "Dom Storage" throughout the codebase \
(including in the ENABLE macro), so we may want to call it "domstorage". \
Like WebSockets and WebSQLDatabase, I think "storage" with no prefix seems \
like a generic storage directory so we should probably call it "webstorage" \
if "domstorage" isn't acceptable.</div>
<div><br></div><div>Indexed Database API:</div><div>"IndexedDB" is what \
it's commonly called, so a directory of "indexeddb" seems like the way \
to go.</div><div><br></div><div>J</div></div> \
<br></div></div><div>_______________________________________________<br> webkit-dev \
mailing list<br> <a href="mailto:webkit-dev@lists.webkit.org" \
target="_blank">webkit-dev@lists.webkit.org</a><br> <a \
href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" \
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br> \
<br></div></blockquote></div><br> </blockquote></div><br>
</div></div></blockquote></div><br>
</div></div></blockquote></div><br>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic