'Re: [webkit-dev] style question for empty for loops'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] style question for empty for loops
From:       David Levin <levin () chromium ! org>
Date:       2010-08-26 20:18:15
Message-ID: AANLkTinGH2JCm7DMo7N1wLw6TMkDYTQ=K23cmqwwNdLK () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

On Thu, Aug 26, 2010 at 1:12 PM, Chris Fleizach <cfleizach@apple.com> wrote:

> webkit-check-style should probably be amended as well
>

Please file a bug. Feel free to cc hamaji@chromium.org, levin@chromium.org,
cjerdonek@webkit.org

>
>
> On Aug 26, 2010, at 12:48 PM, James Robinson wrote:
>
> The style guide currently covers this
> http://webkit.org/coding/coding-style.html:
>
> 4. Control clauses without a body should use empty braces: Right:
>
> for ( ; current; current = current->next) { }
>
> Wrong:
>
> for ( ; current; current = current->next);
>
>
> - James
>
> On Thu, Aug 26, 2010 at 12:22 PM, Chris Fleizach <cfleizach@apple.com>wrote:
>
>>
>> On 26. aug. 2010, at 11.49, Darin Adler wrote:
>>
>> > On Aug 26, 2010, at 11:35 AM, Chris Fleizach wrote:
>> >
>> >>    for (...; ...; ...) { }
>> >
>>
>> So maybe this is the best option. I can add a style guide check for that,
>> unless there are objections
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>

[Attachment #5 (text/html)]

On Thu, Aug 26, 2010 at 1:12 PM, Chris Fleizach <span dir="ltr">&lt;<a \
href="mailto:cfleizach@apple.com">cfleizach@apple.com</a>&gt;</span> wrote:<br><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex;"> <div \
style="word-wrap:break-word">webkit-check-style should probably be amended as \
well</div></blockquote><div><br></div><div>Please file a bug. Feel free to cc <a \
href="mailto:hamaji@chromium.org">hamaji@chromium.org</a>, <a \
href="mailto:levin@chromium.org">levin@chromium.org</a>, <a \
href="mailto:cjerdonek@webkit.org">cjerdonek@webkit.org</a> </div> \
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex;"><div \
style="word-wrap:break-word"><div><div></div><div \
class="h5"><div><br></div><div><br><div> <div>On Aug 26, 2010, at 12:48 PM, James \
Robinson wrote:</div><br><blockquote type="cite">The style guide currently covers \
this <a href="http://webkit.org/coding/coding-style.html" \
target="_blank">http://webkit.org/coding/coding-style.html</a>:<div> <br></div><div>
<span style="font-family:&#39;Lucida Grande&#39;, Verdana, \
Arial;font-size:12px;color:rgb(51, 51, 51);line-height:18px">4. Control clauses \
without a body should use empty braces:</span><h4 \
style="margin-bottom:0px;text-shadow:rgb(187, 187, 187) 1px 1px \
1px;font-size:12px;color:rgb(0, 136, 0) !important;font-family:&#39;Lucida \
Grande&#39;, Verdana, Arial;line-height:18px">

Right:</h4><span style="font-family:&#39;Lucida Grande&#39;, Verdana, \
Arial;font-size:12px;color:rgb(51, 51, 51);line-height:18px"><pre \
style="font-family:Courier, Fixed;font-size:11px;margin-left:2em;line-height:normal"> \
for ( ; current; current = current-&gt;next) { } </pre></span><h4 \
style="margin-bottom:0px;text-shadow:rgb(187, 187, 187) 1px 1px \
1px;font-size:12px;color:rgb(255, 0, 0) !important;font-family:&#39;Lucida \
Grande&#39;, Verdana, Arial;line-height:18px"> Wrong:</h4><span \
style="font-family:&#39;Lucida Grande&#39;, Verdana, \
Arial;font-size:12px;color:rgb(51, 51, 51);line-height:18px"><pre \
style="font-family:Courier, Fixed;font-size:11px;margin-left:2em;line-height:normal"> \
for ( ; current; current = current-&gt;next);</pre></span><div><br></div><div>- \
James</div><br><div class="gmail_quote">On Thu, Aug 26, 2010 at 12:22 PM, Chris \
Fleizach <span dir="ltr">&lt;<a href="mailto:cfleizach@apple.com" \
target="_blank">cfleizach@apple.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div><br> On 26. aug. 2010, at 11.49, Darin Adler wrote:<br>
<br>
&gt; On Aug 26, 2010, at 11:35 AM, Chris Fleizach wrote:<br>
&gt;<br>
&gt;&gt;    for (...; ...; ...) { }<br>
&gt;<br>
<br>
</div>So maybe this is the best option. I can add a style guide check for that, \
unless there are objections<br> <div><div></div><div><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" \
target="_blank">webkit-dev@lists.webkit.org</a><br> <a \
href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" \
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br> \
</div></div></blockquote></div><br></div> \
</blockquote></div><br></div></div></div></div><br>_______________________________________________<br>
 webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" \
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br> \
<br></blockquote></div><br>

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[prev in list] [next in list] [prev in thread] [next in thread] 