[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Web Audio API
From: Chris Rogers <crogers () google ! com>
Date: 2010-08-25 5:00:16
Message-ID: AANLkTi=1QK3H5TmS1y1M4=04ikgpfZbgvNNAdvJwtGVn () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Ok, then it looks like we'll go with this for the directory names:
WebCore/webaudio
WebCore/platform/audio
And this for the feature define:
#if ENABLE(WEB_AUDIO)
Thanks everybody,
Chris
On Tue, Aug 24, 2010 at 9:02 PM, Darin Fisher <darin@chromium.org> wrote:
> On Tue, Aug 24, 2010 at 8:55 PM, Eric Carlson <eric.carlson@apple.com>wrote:
>
>>
>> On Aug 24, 2010, at 8:39 PM, Darin Fisher wrote:
>>
>> My objection (and it's only a slight one) was about using "Web" as a
>> prefix for class names defined in WebCore.
>>
>> WebSockets is the main example of the Web prefix used in WebCore, and
>> that's probably because "sockets" by itself would be too confusing.
>> However, I have found the use of the Web prefix in WebCore to lead to some
>> confusion by itself since WebKit layers tend to use the Web prefix for their
>> classes/interfaces.
>>
>> I realize that the WebCore:: namespace makes this issue technically moot.
>> I'm just concerned about it being confusing to have WebCore::WebFoo and
>> WebKit API level WebFoo.
>>
>> I don't think there is any plan to give the *class* name a "Web" prefix,
>> we are just talking about the names of the WebKit folders and the compile
>> flag.
>>
>> eric
>>
>>
>>
> Ah, OK. Thanks for clearing that up for me. It seemed like things were
> headed toward Web* classes given the contents of this folder:
> http://trac.webkit.org/browser/trunk/WebCore/websockets
> -Darin
>
>
>
>>
>>
>>
>> On Tue, Aug 24, 2010 at 5:29 PM, Chris Rogers <crogers@google.com> wrote:
>>
>>> Good, it looks like we're getting close. So we've agreed to how the
>>> files should be split up, but Darin Fisher still was concerned about the
>>> 'web' prefix.
>>>
>>> Darin, was it the directory name WebCore/webaudio that you didn't like
>>> or:
>>> #if ENABLE(WEB_AUDIO)
>>>
>>> Alternatives might be:
>>>
>>> WebCore/audio or WebCore/audiocontext
>>> #if ENABLE(AUDIO_CONTEXT) or #if ENABLE(AUDIO_API)
>>>
>>> I'm assuming that WebCore/platform/audio we can all agree on...
>>>
>>> Chris
>>>
>>>
>>> On Tue, Aug 24, 2010 at 5:20 PM, Simon Fraser <simon.fraser@apple.com>wrote:
>>>
>>>> On Aug 24, 2010, at 4:47 PM, Chris Rogers wrote:
>>>>
>>>> Hi Simon, thanks for helping here.
>>>>
>>>> By the way, anybody who is interested can look at the files in:
>>>> https://svn.webkit.org/repository/webkit/branches/audio/WebCore/audio/
>>>>
>>>> There are actually a number of audio files which could be considered
>>>> re-usable, although I know of nothing at this time other than the web audio
>>>> API which would use them:
>>>>
>>>> AudioBus.cpp
>>>> Biquad.cpp
>>>> Reverb.cpp
>>>> FFTConvolver.cpp (and other FFT-related files)
>>>>
>>>> possibly also in this category are:
>>>> Cone.cpp
>>>> Distance.cpp
>>>> MidSide.cpp
>>>> SinWave.cpp
>>>> Panner.cpp (and subclasses)
>>>> (maybe a few others I've missed)
>>>>
>>>> Basically, these are the lowest-level building blocks which the
>>>> higher-level parts (such as AudioContext, and AudioNode) use. These
>>>> lowest-level building blocks do not (or should not) have any dependencies to
>>>> the higher-level code which implement the actual API (and have IDL files).
>>>> They also don't have any dependencies on other parts of WebCore, although
>>>> they do use stuff in wtf.
>>>>
>>>> So are you suggesting:
>>>>
>>>> WebCore/webaudio <--- IDL files and API implementation
>>>> WebCore/platform/audio <--- lower-level building blocks such as
>>>> AudioBus.cpp
>>>>
>>>>
>>>> Fine by me!
>>>>
>>>>
>>>> then with the conditional
>>>>
>>>> #if WEB_AUDIO <----- I added an underscore here
>>>>
>>>>
>>>> That would be #if ENABLE(WEB_AUDIO) in the code.
>>>>
>>>> Simon
>>>>
>>>>
>>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>>
>
[Attachment #5 (text/html)]
Ok, then it looks like we'll go with this for the directory \
names:<div><br><div><div><span class="Apple-style-span" style="font-family: arial, \
sans-serif; font-size: 12.5px; border-collapse: collapse; \
"><div>WebCore/webaudio</div> \
<div>WebCore/platform/audio</div><div><br></div><div>And this for the feature \
define:</div><div>#if ENABLE(WEB_AUDIO)<br></div><div><br></div><div>Thanks \
everybody,</div><div>Chris</div><div><span class="Apple-style-span" \
style="border-collapse: separate; font-size: small;"><font class="Apple-style-span" \
size="5"><span class="Apple-style-span" style="border-collapse: collapse; font-size: \
18px;"><br> </span></font></span></div></span></div><div><div class="gmail_quote">On \
Tue, Aug 24, 2010 at 9:02 PM, Darin Fisher <span dir="ltr"><<a \
href="mailto:darin@chromium.org">darin@chromium.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="im">On Tue, Aug 24, 2010 at 8:55 PM, Eric \
Carlson <span dir="ltr"><<a href="mailto:eric.carlson@apple.com" \
target="_blank">eric.carlson@apple.com</a>></span> wrote:<br></div><div \
class="gmail_quote"><div class="im"> <blockquote class="gmail_quote" style="margin:0 \
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
style="word-wrap:break-word"><br><div><div><div>On Aug 24, 2010, at 8:39 PM, Darin \
Fisher wrote:</div><br><blockquote type="cite">My objection (and it's only a \
slight one) was about using "Web" as a prefix for class names defined in \
WebCore.<div>
<br></div><div>WebSockets is the main example of the Web prefix used in WebCore, and \
that's probably because "sockets" by itself would be too confusing. \
However, I have found the use of the Web prefix in WebCore to lead to some confusion \
by itself since WebKit layers tend to use the Web prefix for their \
classes/interfaces.</div>
<div><br></div><div>I realize that the WebCore:: namespace makes this issue \
technically moot. I'm just concerned about it being confusing to have \
WebCore::WebFoo and WebKit API level WebFoo.</div><div><div><br></div>
</div></blockquote></div><div> I don't think there is any plan to give the \
*class* name a "Web" prefix, we are just talking about the names of the \
WebKit folders and the compile flag.</div><div><br></div><font color="#888888"><div>
eric</div><div><br></div><div><br></div></font></div></div></blockquote><div><br></div></div><div>Ah, \
OK. Thanks for clearing that up for me. It seemed like things were headed toward \
Web* classes given the contents of this folder: <a \
href="http://trac.webkit.org/browser/trunk/WebCore/websockets" \
target="_blank">http://trac.webkit.org/browser/trunk/WebCore/websockets</a></div>
<div>-Darin</div><div><div></div><div class="h5"><div><br></div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word"><div><font \
color="#888888"><div> </div><br>
</font><blockquote type="cite"><div><div></div><div><div>
<div><br></div><div><br><div class="gmail_quote">On Tue, Aug 24, 2010 at 5:29 PM, \
Chris Rogers <span dir="ltr"><<a href="mailto:crogers@google.com" \
target="_blank">crogers@google.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
Good, it looks like we're getting close. So we've agreed to how the files \
should be split up, but Darin Fisher still was concerned about the 'web' \
prefix.<div><br></div><div>Darin, was it the directory name WebCore/webaudio that you \
didn't like or:</div>
<div>#if ENABLE(WEB_AUDIO)</div><div><br></div><div>Alternatives might \
be:</div><div><br></div><div>WebCore/audio or \
WebCore/audiocontext</div><div><div>#if ENABLE(AUDIO_CONTEXT) or #if \
ENABLE(AUDIO_API)</div>
</div><div><br></div><div>I'm assuming that WebCore/platform/audio we can all \
agree on...</div><div><br></div><font \
color="#888888"><div>Chris</div></font><div><div></div><div><div><br></div><div><br><div \
class="gmail_quote">
On Tue, Aug 24, 2010 at 5:20 PM, Simon Fraser <span dir="ltr"><<a \
href="mailto:simon.fraser@apple.com" \
target="_blank">simon.fraser@apple.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div>On Aug 24, \
2010, at 4:47 PM, Chris Rogers wrote:</div><br> <blockquote type="cite">Hi Simon, \
thanks for helping here.<div><br></div><div><div>By the way, anybody who is \
interested can look at the files in:</div><div><a \
href="https://svn.webkit.org/repository/webkit/branches/audio/WebCore/audio/" \
target="_blank">https://svn.webkit.org/repository/webkit/branches/audio/WebCore/audio/</a></div>
</div><div><br></div><div>There are actually a number of audio files which could be \
considered re-usable, although I know of nothing at this time other than the web \
audio API which would use them:</div><div><br></div><div>
AudioBus.cpp</div><div>Biquad.cpp</div><div>Reverb.cpp</div><div>FFTConvolver.cpp \
(and other FFT-related files)</div><div><br></div><div>possibly also in this category \
are:</div><div>Cone.cpp</div><div>Distance.cpp</div>
<div>
MidSide.cpp</div><div>SinWave.cpp</div><div>Panner.cpp (and \
subclasses)</div><div>(maybe a few others I've \
missed)</div><div><br></div><div>Basically, these are the lowest-level building \
blocks which the higher-level parts (such as AudioContext, and AudioNode) use. These \
lowest-level building blocks do not (or should not) have any dependencies to the \
higher-level code which implement the actual API (and have IDL files). They also \
don't have any dependencies on other parts of WebCore, although they do use stuff \
in wtf.</div>
<div><br></div><div>So are you suggesting:</div><div><br></div><div>WebCore/webaudio \
<--- IDL files and API implementation</div><div>WebCore/platform/audio \
<--- lower-level building blocks such as AudioBus.cpp</div>
</blockquote><div><br></div></div>Fine by me!</div><div><div><br><blockquote \
type="cite"> <div><br></div><div>then with the \
conditional</div><div><br></div><div>#if WEB_AUDIO <----- I added an \
underscore here</div></blockquote><br></div></div><div>That would be #if \
ENABLE(WEB_AUDIO) in the code.</div>
<br><font color="#888888"><div>Simon</div><div><br></div></font></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div></div><div>
_______________________________________________<br>webkit-dev mailing list<br><a \
href="mailto:webkit-dev@lists.webkit.org" \
target="_blank">webkit-dev@lists.webkit.org</a><br><a \
href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" \
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</div></blockquote></div><br></div>
</blockquote></div></div></div><br>
</blockquote></div><br></div></div></div>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic