[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Style guide for indenting nested #if #define in
From:       Eric Seidel <eric () webkit ! org>
Date:       2009-10-15 16:01:17
Message-ID: 1448d9f30910150901n48f204b5u694fe764362397a1 () mail ! gmail ! com
[Download RAW message or body]

http://trac.webkit.org/changeset/48525 was the first time I saw it.

On Thu, Oct 15, 2009 at 11:56 AM, Chris Marrin <cmarrin@apple.com> wrote:
> 
> On Oct 15, 2009, at 8:54 AM, Timothy Hatcher wrote:
> 
> > This is rather ugly and does not match the majority of the code we have in \
> > WebCore already.
> 
> I agree. I don't find any issues with the current, unindented style. I just think \
> that ifdefs that span more than 10 lines or so should always put the condition on \
> the #endif as a comment. 
> > 
> > On Oct 15, 2009, at 8:12 AM, Eric Seidel wrote:
> > 
> > > I really like the indented style that some folks have started using:
> > > 
> > > #if foo
> > > #    define BAR BAZ
> > > #else
> > > #    define BAR BARF
> > > #endif
> > > 
> > > I think we should standardize on something and add it to the style guides.
> > 
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> -----
> ~Chris
> cmarrin@apple.com
> 
> 
> 
> 
> 
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]