[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] I *HATE* CHANGELOGS!!!
From: Geoffrey Garen <ggaren () apple ! com>
Date: 2009-08-28 21:28:50
Message-ID: 9AF152FB-E8FC-47CF-B51C-A4F7CCD86EC4 () apple ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> "I can imagine a discipline where we ensure that pending commit
> entries sit in a designated file in your tree, are made by a tool
> much like prepare-ChangeLog, are included in patches by svn-create-
> patch, are applied by svn-apply-patch, and are used by commit-log-
> editor. That would ensure the entries go through the patch life
> cycle just as much as currently."
>
> Slightly more concrete. prepare-ChangeLog is modified to create a
> ".changelog" file in the root of your checkout. Then svn-create-
> patch, svn-apply-patch and commit-log-editor all use the .changelog
> file to prepend your change description to the actual ChangeLog file
> before doing their thing.
I don't think Maciej was proposing prepending the contents of your
proposed .changelog to an actual ChangeLog file. I think he was
proposing:
* prepare-ChangeLog creates (or overwrites, if existing) a .changelog
file describing your change
* You modify .changelog to add informative notes
* svn-create-patch includes .changelog in the patch it outputs, even
though it is not in the version control system
* svn-apply and svn-unapply honor changes to .changelog, but never
"svn add" it to the version control system
* commit-log-editor pastes .changelog into the top of your commit
message (or you can do so manually if commit-log-editor is not set up
on your system)
> Does anyone actually have any objections to Maciej's proposal?
I have only one [relatively minor] objection: I can't return to using
svn-create-patch until https://bugs.webkit.org/show_bug.cgi?id=28623
is fixed.
Geoff
[Attachment #5 (unknown)]
<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; "><div><blockquote type="cite"><div>"<span \
style="font-family:arial, sans-serif;font-size:13px;border-collapse:collapse">I can \
imagine a discipline where we ensure that pending commit entries sit in a designated \
file in your tree, are made by a tool much like prepare-ChangeLog, are included in \
patches by svn-create-patch, are applied by svn-apply-patch, and are used by \
commit-log-editor. That would ensure the entries go through the patch life cycle just \
as much as currently."</span></div>
<div><font face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px"><br></span></font></div><div><font \
face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px">Slightly more concrete. \
prepare-ChangeLog is modified to create a ".changelog" file in the root of your \
checkout. Then svn-create-patch, svn-apply-patch and commit-log-editor all use the \
.changelog file to prepend your change description to the actual ChangeLog file \
before doing their thing.</span></font></div></blockquote><div><br></div></div>I \
don't think Maciej was proposing prepending the contents of your proposed .changelog \
to an actual ChangeLog file. I think he was proposing:<div><br></div><div>* \
prepare-ChangeLog creates (or overwrites, if existing) a .changelog file describing \
your change</div><div>* You modify .changelog to add informative notes</div><div>* \
svn-create-patch includes .changelog in the patch it outputs, even though it is not \
in the version control system</div><div>* svn-apply and svn-unapply honor \
changes to .changelog, but never "svn add" it to the version control \
system</div><div>* commit-log-editor pastes .changelog into the top of your commit \
message (or you can do so manually if commit-log-editor is not set up on your \
system)</div><div><br></div><div><div><blockquote type="cite">Does anyone actually \
have any objections to Maciej's proposal?</blockquote></div><div><br></div><div>I \
have only one [relatively minor] objection: I can't return to using svn-create-patch \
until <a href="https://bugs.webkit.org/show_bug.cgi?id=28623">https://bugs.webkit.org/show_bug.cgi?id=28623</a> \
is fixed.</div><div><br></div><div>Geoff</div></div></body></html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic