[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] I *HATE* CHANGELOGS!!!
From: Ojan Vafai <ojan () chromium ! org>
Date: 2009-08-28 20:37:11
Message-ID: 78dc8440908281337h55547098w1886972f93a4ba0b () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Fri, Aug 28, 2009 at 1:18 PM, Brady Eidson <beidson@apple.com> wrote:
> On Aug 28, 2009, at 1:15 PM, David Kilzer wrote:
>
>> On Friday, August 28, 2009 at 1:05:57 PM, Jeremy Orlow wrote:
>>
>>> On Fri, Aug 28, 2009 at 12:26 PM, Brady Eidson wrote:
>>>
>>>> Mark Rowe already pointed out - doing an automated step for
>>>> each checkin that causes another checkin would be ridiculous.
>>>> But how about a nightly script that checks in a ChangeLog
>>>> accounting for the day's commits?
>>>>
>>>
>>> Agreed. If it's done daily, Trac would be a good way to look
>>> at what's happened very recently.
>>>
>>
>> This would make it impossible to track a single ChangeLog entry back to
>> the original commit using git/svn annotate/blame, but the new process could
>> add the commit revision to each ChangeLog entry automatically when it
>> generates the update, thus achieving some level of ChangeLog-nirvana.
>>
>
Does anyone actually have any objections to Maciej's proposal?
"I can imagine a discipline where we ensure that pending commit entries sit
in a designated file in your tree, are made by a tool much like
prepare-ChangeLog, are included in patches by svn-create-patch, are applied
by svn-apply-patch, and are used by commit-log-editor. That would ensure the
entries go through the patch life cycle just as much as currently."
Slightly more concrete. prepare-ChangeLog is modified to create a
".changelog" file in the root of your checkout. Then svn-create-patch,
svn-apply-patch and commit-log-editor all use the .changelog file to prepend
your change description to the actual ChangeLog file before doing their
thing.
Are there any downsides to that proposal?
Ojan
[Attachment #5 (text/html)]
<div class="gmail_quote">On Fri, Aug 28, 2009 at 1:18 PM, Brady Eidson <span \
dir="ltr"><<a href="mailto:beidson@apple.com" \
target="_blank">beidson@apple.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>On Aug 28, 2009, at 1:15 PM, David Kilzer wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> On Friday, August 28, 2009 at 1:05:57 PM, Jeremy Orlow \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> On Fri, Aug 28, 2009 at 12:26 PM, Brady Eidson \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> Mark Rowe already pointed out - doing an automated step \
for<br> each checkin that causes another checkin would be ridiculous.<br>
But how about a nightly script that checks in a ChangeLog<br>
accounting for the day's commits?<br>
</blockquote>
<br>
Agreed. If it's done daily, Trac would be a good way to look<br>
at what's happened very recently.<br>
</blockquote>
<br>
This would make it impossible to track a single ChangeLog entry back to the original \
commit using git/svn annotate/blame, but the new process could add the commit \
revision to each ChangeLog entry automatically when it generates the update, thus \
achieving some level of ChangeLog-nirvana.<br>
</blockquote>
</div></blockquote></div><br><div>Does anyone actually have any objections to \
Maciej's proposal?</div><div><br></div><div>"<span style="font-family:arial, \
sans-serif;font-size:13px;border-collapse:collapse">I can imagine a discipline where \
we ensure that pending commit entries sit in a designated file in your tree, are made \
by a tool much like prepare-ChangeLog, are included in patches by svn-create-patch, \
are applied by svn-apply-patch, and are used by commit-log-editor. That would ensure \
the entries go through the patch life cycle just as much as \
currently."</span></div>
<div><font face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px"><br></span></font></div><div><font \
face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px">Slightly more concrete. \
prepare-ChangeLog is modified to create a ".changelog" file in the root of \
your checkout. Then svn-create-patch, svn-apply-patch and commit-log-editor all use \
the .changelog file to prepend your change description to the actual ChangeLog file \
before doing their thing.</span></font></div>
<div><font face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px"><br></span></font></div><div><font \
face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px">Are there any downsides to that \
proposal?</span></font></div>
<div><font face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px"><br></span></font></div><div><font \
face="arial, sans-serif" size="3"><span \
style="border-collapse:collapse;font-size:13px">Ojan</span></font></div>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic