[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] I *HATE* CHANGELOGS!!!
From:       Peter Kasting <pkasting () google ! com>
Date:       2009-08-27 0:30:06
Message-ID: d62cf1d10908261730y23dd5203we2910dc93a090c8b () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Aug 26, 2009 at 4:51 PM, Darin Adler <darin@apple.com> wrote:

> I get lots of history about the bug, including bug numbers that point me =
at
> bugs.webkit.org and even Apple=92s internal Radar. And I often use the da=
te
> to follow up reading the change in trac.
>
> On the projects I=92ve worked on with more low key change description
> disciplines, I find that check-in comments or their equivalents are vague=
,
> and missing critical information like the name of the reviewer, whether t=
he
> code is tested, the nature of the bug being fixed, and the nature of the
> fix.
>
> I agree that in theory we could find a different way of doing the project
> that still encourages people to communicate these things, but I am
> skeptical.


Detailed descriptions, bug links, test instructions, and a link back to the
entire original review history are all part of Chromium commits, yet we
don't use ChangeLogs.  I think discipline about what to include + tooling t=
o
support it are orthogonal to a project's use of a ChangeLog as the mechanis=
m
for conveying this information.

PK

[Attachment #5 (text/html)]

<div class="gmail_quote">On Wed, Aug 26, 2009 at 4:51 PM, Darin Adler <span \
dir="ltr">&lt;<a href="mailto:darin@apple.com">darin@apple.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="im">I get lots of history about the bug, \
including bug numbers that point me at <a href="http://bugs.webkit.org" \
target="_blank">bugs.webkit.org</a> and even Apple’s internal Radar. And I often use \
the date to follow up reading the change in trac.</div>

<br>
On the projects I’ve worked on with more low key change description disciplines, I \
find that check-in comments or their equivalents are vague, and missing critical \
information like the name of the reviewer, whether the code is tested, the nature of \
the bug being fixed, and the nature of the fix.<br>

<br>
I agree that in theory we could find a different way of doing the project that still \
encourages people to communicate these things, but I am \
skeptical.</blockquote><div><br></div><div>Detailed descriptions, bug links, test \
instructions, and a link back to the entire original review history are all part of \
Chromium commits, yet we don&#39;t use ChangeLogs.  I think discipline about what to \
include + tooling to support it are orthogonal to a project&#39;s use of a ChangeLog \
as the mechanism for conveying this information.</div> \
<div><br></div><div>PK</div></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]