[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] I *HATE* CHANGELOGS!!!
From:       Brady Eidson <beidson () apple ! com>
Date:       2009-08-27 0:19:52
Message-ID: A72D5FB2-CAF0-4D2C-9579-F082C6B6C50C () apple ! com
[Download RAW message or body]


On Aug 26, 2009, at 4:20 PM, Mark Rowe wrote:

>
> On 2009-08-26, at 15:43, Maciej Stachowiak wrote:
>
>>> On top of that sometimes the ChangeLog merges cleanly but puts  
>>> your entry underneath others, and then you have to open the file  
>>> and move your entry back to the top.  Sometimes I have not noticed  
>>> this and then I land with someone else's commit message.
>>>
>>> I just don't get why people are willing to put up with this.  It's  
>>> really driving me crazy.
>>
>> One possibility is to have a commit hook that builds the ChangeLog  
>> entry and includes it in the commit atomically - that way there are  
>> no races.
>
> Hooks in Subversion cannot mutate the transaction that is taking  
> place so I don't think this is an option.

Is there any sort of guarantee that a post commit hook for revision N  
will complete before the post commit hook for revision N + 1 executes?

Couldn't that accomplish this?

~Brady

>
> - Mark
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic