[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs
From:       Peter Kasting <pkasting () google ! com>
Date:       2009-05-25 22:16:15
Message-ID: d62cf1d10905251516v57da4e37l5cb6d3a39ffd7ed0 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, May 25, 2009 at 1:33 PM, Mark Rowe <mrowe@apple.com> wrote:

> Xcode and GCC on Mac OS X avoid this issue by building a map of header
> files in the project and their locations on disk, so the compiler doesn't
> have to walk the header entire search path every time you include a file.
>  It's unfortunate if other compilers aren't smart enough to work well with
> this incredibly common approach to #includes and header search paths.
>

FWIW, it's also clearer -- seeing at a glance to Foo.h is from
WebCore/platform versus WebCore/page is good information (and no one has
every single header's origin and meaning in their heads).

Increased clarity, fewer errors/conflicts, and a giant speedup on some
compilers seem worth the (IMO minor) cost of having to do a
search-and-replace when moving headers around.

I didn't really mean to derail the existing discussion, though.  This isn't
really the same topic.

PK

[Attachment #5 (text/html)]

<div class="gmail_quote">On Mon, May 25, 2009 at 1:33 PM, Mark Rowe <span \
dir="ltr">&lt;<a href="mailto:mrowe@apple.com">mrowe@apple.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div style="word-wrap:break-word"><div \
class="im">Xcode and GCC on Mac OS X avoid this issue by building a map of header \
files in the project and their locations on disk, so the compiler doesn&#39;t have to \
walk the header entire search path every time you include a file.  It&#39;s \
unfortunate if other compilers aren&#39;t smart enough to work well with this \
incredibly common approach to #includes and header search paths.</div> \
<div></div></div></blockquote><div><br></div><div>FWIW, it&#39;s also clearer -- \
seeing at a glance to Foo.h is from WebCore/platform versus WebCore/page is good \
information (and no one has every single header&#39;s origin and meaning in their \
heads).</div> <div><br></div><div>Increased clarity, fewer errors/conflicts, and a \
giant speedup on some compilers seem worth the (IMO minor) cost of having to do a \
search-and-replace when moving headers around.</div><div><br></div><div> I didn&#39;t \
really mean to derail the existing discussion, though.  This isn&#39;t really the \
same topic.</div><div><br></div><div>PK</div></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]