[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs
From:       Peter Kasting <pkasting () google ! com>
Date:       2009-05-25 20:19:51
Message-ID: d62cf1d10905251319tb0c6e97l1b8e7704a05c43d3 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, May 25, 2009 at 12:49 AM, Maciej Stachowiak <mjs@apple.com> wrote:

> Now, the thing I _would_ like to change is to switch from pathless
> #includes to ones with relative paths -- but that's a totally different
> thread.
>
>
> That I definitely wouldn't like. It would make it much more painful to move
> files. What is the benefit? Maybe UI am missing something.
>

Massively decreased compile time.  We've measured and the time taken to
search the various #include paths is large.  Occasionally this pathless
solution can also cause issues when there are multiple headers with the same
name in the project (we ran into this a number of times over the course of
Chromium development).

On the Chromium side, we follow the Google style guide, which mandates paths
on #includes, and we've rearranged our entire source layout a number of
times.  It doesn't turn out to be a huge problem and the compile-speed
benefits are well worth it.

PK

[Attachment #5 (text/html)]

<div class="gmail_quote">On Mon, May 25, 2009 at 12:49 AM, Maciej Stachowiak <span \
dir="ltr">&lt;<a href="mailto:mjs@apple.com">mjs@apple.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div style="word-wrap:break-word"><div><div \
class="im"><blockquote type="cite"><div class="gmail_quote"><div>Now, the thing I \
_would_ like to change is to switch from pathless #includes to ones with relative \
paths -- but that&#39;s a totally different thread.</div> \
</div></blockquote><br></div></div><div>That I definitely wouldn&#39;t like. It would \
make it much more painful to move files. What is the benefit? Maybe UI am missing \
something.</div><div></div></div></blockquote><div><br> </div><div>Massively \
decreased compile time.  We&#39;ve measured and the time taken to search the various \
#include paths is large.  Occasionally this pathless solution can also cause issues \
when there are multiple headers with the same name in the project (we ran into this a \
number of times over the course of Chromium development).</div> \
<div><br></div><div>On the Chromium side, we follow the Google style guide, which \
mandates paths on #includes, and we&#39;ve rearranged our entire source layout a \
number of times.  It doesn&#39;t turn out to be a huge problem and the compile-speed \
benefits are well worth it.</div> <div><br></div><div>PK</div></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]