[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] #if PLATFORM(CF) || (PLATFORM(QT) &&
From:       Darin Fisher <darin () chromium ! org>
Date:       2009-01-30 17:10:16
Message-ID: bd8f24d20901300910k135de9e8r303c27bdd8859422 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Just speculating, but probably because there are cases where a QT API should
be used instead of a CF API.  This probably just happens to be a time when
the CF API is preferred (maybe a QT alternative does not exist?).
(We are in a similar boat with PLATFORM(CHROMIUM), which is why this topic
is especially interesting to me.)

-Darin


On Fri, Jan 30, 2009 at 8:59 AM, Darin Adler <darin@apple.com> wrote:

> I noticed that code relating to Core Foundation has the ifdef above:
>
>    #if PLATFORM(CF) || (PLATFORM(QT) && PLATFORM(DARWIN))
>
> This seems wrong. Why doesn't the CF platform switch get set when compiling
> with Qt and Darwin? It should. Does it cause problems? Can we just fix
> those?
>
>    -- Darin
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>

[Attachment #5 (text/html)]

Just speculating, but probably because there are cases where a QT API should be used \
instead of a CF API. &nbsp;This probably just happens to be a time when the CF API is \
preferred (maybe a QT alternative does not exist?).<div> <br></div><div>(We are in a \
similar boat with PLATFORM(CHROMIUM), which is why this topic is especially \
interesting to me.)</div><div><br></div><div>-Darin</div><div><br><br><div \
class="gmail_quote">On Fri, Jan 30, 2009 at 8:59 AM, Darin Adler <span \
dir="ltr">&lt;<a href="mailto:darin@apple.com">darin@apple.com</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">I noticed that code relating to Core Foundation has the \
ifdef above:<br> <br>
 &nbsp; &nbsp;#if PLATFORM(CF) || (PLATFORM(QT) &amp;&amp; PLATFORM(DARWIN))<br>
<br>
This seems wrong. Why doesn&#39;t the CF platform switch get set when compiling with \
Qt and Darwin? It should. Does it cause problems? Can we just fix those?<br> <br>
 &nbsp; &nbsp;-- Darin<br>
<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" \
target="_blank">webkit-dev@lists.webkit.org</a><br> <a \
href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" \
target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br> \
</blockquote></div><br></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]