[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] renaming ASSERT macro
From:       Jörg_Bornemann <joerg.bornemann () trolltech ! com>
Date:       2008-07-01 8:45:02
Message-ID: 4869EE8E.3090705 () trolltech ! com
[Download RAW message or body]

Darin Adler wrote:

>> Well, this is a small change but also a very bad idea. Not because of
>> compilation time, but because of the crappy Windows headers which define
>> *a* *lot* of global stuff. E.g. the XSLT parser of WebKit won't build
>> because there's a "#define ERROR <somenumber>" which breaks an enum
>> definition. Or think of the famous MIN / MAX definitions, which drive
>> every crossplatform developer insane.
> 
> OK. Lets #undef those things.

This solution is easy to do, leads to the smallest source diff but is a 
very dirty hack, which will lead to problems on WinCE, because we will 
include windows.h in public headers. One survival rule of Windows 
developers is: only include windows.h when it is really needed.

So what's your argument against the clean solution (renaming)?


Regards,

Jörg
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[prev in list] [next in list] [prev in thread] [next in thread]