[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [WebKit/WebKit] 33d8a4: Add some tests that decide to download after an HT...
From:       Alex Christensen <noreply () github ! com>
Date:       2024-01-31 21:01:58
Message-ID: WebKit/WebKit/push/refs/heads/main/aeb361-33d8a4 () github ! com
[Download RAW message or body]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33d8a411c327e0b5afa05799bb9a2935c46b19f4
      https://github.com/WebKit/WebKit/commit/33d8a411c327e0b5afa05799bb9a2935c46b19f4
  Author: Alex Christensen <achristensen@apple.com>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm

  Log Message:
  -----------
  Add some tests that decide to download after an HTTP redirection
https://bugs.webkit.org/show_bug.cgi?id=268350
rdar://121891934

Reviewed by Charlie Wolfe.

Choosing to download only after seeing a redirect response is a case that has no tests.
It currently uses much of the same code paths as choosing to download when initially seeing
a navigation action, but with some upcoming work I'm planning to make them different code
paths, so it's important to add a test for this case to verify existing behavior does not change.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
* Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
(-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
(-[TestNavigationDelegate webView:navigationAction:didBecomeDownload:]):
(-[TestNavigationDelegate webView:navigationResponse:didBecomeDownload:]):

Canonical link: https://commits.webkit.org/273854@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]