[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [WebKit/WebKit] 25ead8: [web-animations] keyframes should be recomputed wh...
From:       Antoine Quint <noreply () github ! com>
Date:       2023-01-31 22:06:16
Message-ID: WebKit/WebKit/push/refs/heads/main/c7d795-25ead8 () github ! com
[Download RAW message or body]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25ead8e66edd255e51c4114a6216330aca3d181b
      https://github.com/WebKit/WebKit/commit/25ead8e66edd255e51c4114a6216330aca3d181b
  Author: Antoine Quint <graouts@webkit.org>
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/responsive/column-rule-color-001-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/responsive/column-width-001-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/baselineShift-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/clip-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnCount-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnGap-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/offsetRotate-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/opacity-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/perspective-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/rowGap-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/shapeOutside-expected.txt
  M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/to-color-change-expected.txt
  M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/animation/KeyframeEffectStack.cpp

  Log Message:
  -----------
  [web-animations] keyframes should be recomputed when a parent element changes value \
for a non-inherited property set to "inherit" \
https://bugs.webkit.org/show_bug.cgi?id=248152

Reviewed by Antti Koivisto.

In the case where a non-inherited property is set to "inherit" on a keyframe, we now \
update keyframes each time animations are updated in case the parent style changed \
value. While this is not optimal, this is bound to be a pretty rare scenario which we \
can improve on later if we deem it necessary.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/responsive/column-rule-color-001-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/responsive/column-width-001-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/baselineShift-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/clip-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnCount-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnGap-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/offsetRotate-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/opacity-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/perspective-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/rowGap-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/shapeOutside-expected.txt:
                
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/to-color-change-expected.txt:
                
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
(WebCore::KeyframeEffect::computeHasExplicitlyInheritedKeyframeProperty):
* Source/WebCore/animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::hasExplicitlyInheritedKeyframeProperty const):
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::applyKeyframeEffects):

Canonical link: https://commits.webkit.org/259645@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread]