[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [WebKit/WebKit] 763cf9: Add size assert for Element
From:       Rob Buis <noreply () github ! com>
Date:       2022-12-31 8:25:29
Message-ID: WebKit/WebKit/push/refs/heads/main/e961ef-763cf9 () github ! com
[Download RAW message or body]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 763cf9e589db3899e951e9efa3bf60ff61656583
      https://github.com/WebKit/WebKit/commit/763cf9e589db3899e951e9efa3bf60ff61656583
  Author: Rob Buis <rbuis@igalia.com>
  Date:   2022-12-31 (Sat, 31 Dec 2022)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/EventTarget.h

  Log Message:
  -----------
  Add size assert for Element
https://bugs.webkit.org/show_bug.cgi?id=249295

Reviewed by Yusuke Suzuki.

To keep Element a reasonable size move two existing flags
to rare data and add a static_assert to verify that
Element does not grow in the future.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::hasDuplicateAttribute const):
(WebCore::Element::setHasDuplicateAttribute):
(WebCore::Element::displayContentsChanged const):
(WebCore::Element::setDisplayContentsChanged):
* Source/WebCore/dom/Element.h:
(WebCore::Element::hasDuplicateAttribute const): Deleted.
(WebCore::Element::setHasDuplicateAttribute): Deleted.
(WebCore::Element::displayContentsChanged const): Deleted.
(WebCore::Element::setDisplayContentsChanged): Deleted.
* Source/WebCore/dom/EventTarget.h:

Canonical link: https://commits.webkit.org/258366@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]