[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [WebKit/WebKit] c2f1bd: "<CATransformLayer> changing property contentsScal...
From:       Simon Fraser <noreply () github ! com>
Date:       2022-12-30 23:56:13
Message-ID: WebKit/WebKit/push/refs/heads/main/f54ab6-c2f1bd () github ! com
[Download RAW message or body]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2f1bd3f763bca4b4b769f0dad4334ec28a25832
      https://github.com/WebKit/WebKit/commit/c2f1bd3f763bca4b4b769f0dad4334ec28a25832
  Author: Simon Fraser <simon.fraser@apple.com>
  Date:   2022-12-30 (Fri, 30 Dec 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

  Log Message:
  -----------
  "<CATransformLayer> changing property contentsScale in transform-only layer, will \
have no effect" logging https://bugs.webkit.org/show_bug.cgi?id=249946
rdar://103762578

Reviewed by Tim Horton.

In 253606@main I made it possible for the primary layer of a GraphicsLayer to be a \
CATransformLayer. However, we had existing code that unconditionally cause \
-contentsScale and -rasterizationScale to be set on all CALayers, and these don't \
make sense on a CATransformLayer, which never has painted content.

So conditionalize calling `noteLayerPropertyChanged(ContentsScaleChanged)` to only \
happen on non-transform layers.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::initialize):

Canonical link: https://commits.webkit.org/258364@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread]