[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [259277] trunk/Source/WebInspectorUI
From: nvasilyev () apple ! com
Date: 2020-03-31 3:32:05
Message-ID: 20200331033205.E426310051CE () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[259277] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/259277">259277</a></dd> \
<dt>Author</dt> <dd>nvasilyev@apple.com</dd> <dt>Date</dt> <dd>2020-03-30 20:32:05 \
-0700 (Mon, 30 Mar 2020)</dd> </dl>
<h3>Log Message</h3>
<pre>Web Inspector: the Dock Side navigation item is automatically focused when Web \
Inspector is opened detached, preventing any global spacebar shortcuts from working \
https://bugs.webkit.org/show_bug.cgi?id=209760
Reviewed by Devin Rousso.
When undocking, Web Inspector focuses on the first visible focusable element. I don't \
know why. This patch restores the focus to the previously focused element.
* UserInterface/Base/Main.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (259276 => \
259277)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2020-03-31 03:12:12 UTC \
(rev 259276)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-03-31 03:32:05 UTC (rev 259277)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2020-03-30 Nikita Vasilyev <nvasilyev@apple.com>
+
+ Web Inspector: the Dock Side navigation item is automatically focused when \
Web Inspector is opened detached, preventing any global spacebar shortcuts from \
working + https://bugs.webkit.org/show_bug.cgi?id=209760
+
+ Reviewed by Devin Rousso.
+
+ When undocking, Web Inspector focuses on the first visible focusable \
element. I don't know why. + This patch restores the focus to the previously \
focused element. +
+ * UserInterface/Base/Main.js:
+
</ins><span class="cx"> 2020-03-30 Devin Rousso <drousso@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: REGRESSION(r259101): items in the \
contextmenu of the tab bar don't have any text </span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (259276 => 259277)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-03-31 03:12:12 UTC (rev \
259276)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-03-31 03:32:05 UTC \
(rev 259277) </span><span class="lines">@@ -901,6 +901,19 @@
</span><span class="cx">
</span><span class="cx"> if (!WI.dockedConfigurationSupportsSplitContentBrowser() \
&& !WI.doesCurrentTabSupportSplitContentBrowser()) </span><span class="cx"> \
WI.hideSplitConsole(); </span><ins>+
+ if (side === WI.DockConfiguration.Undocked && WI.Platform.name === \
"mac") { + // When undocking, the first visible focusable element \
steals focus. Undo this. + document.body.addEventListener("focusin", \
function(event) { + let firstFocusableElement = \
document.querySelector("[tabindex='0']:not(.hidden)"); + if \
(firstFocusableElement === event.target) { + if \
(WI.previousFocusElement) + WI.previousFocusElement.focus();
+ else
+ event.target.blur();
+ }
+ }, {once: true, capture: true});
+ }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WI.resizeDockedFrameMouseDown = function(event)
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic