[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [259257] branches/safari-609-branch/Source/JavaScriptCore
From: repstein () apple ! com
Date: 2020-03-31 0:42:31
Message-ID: 20200331004231.D495D10051CE () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[259257] branches/safari-609-branch/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/259257">259257</a></dd> \
<dt>Author</dt> <dd>repstein@apple.com</dd> <dt>Date</dt> <dd>2020-03-30 17:42:31 \
-0700 (Mon, 30 Mar 2020)</dd> </dl>
<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/258540">r258540</a>. \
rdar://problem/61064830
[JSC] JSMapIterator and JSSetIterator are CellType
https://bugs.webkit.org/show_bug.cgi?id=209168
<rdar://problem/59705631>
Reviewed by Saam Barati.
They are JSCell, not JSObject since they are not used as a user-observable \
set/map iterators in JSC. However, their JSType is ObjectType. They should use \
CellType instead.
* runtime/JSMapIterator.h:
* runtime/JSSetIterator.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258540 \
268f45cc-cd09-0410-ab3c-d52691b4dbfc</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari609branchSourceJavaScriptCoreChangeLog">branches/safari-609-branch/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchessafari609branchSourceJavaScriptCoreruntimeJSMapIteratorh">branches/safari-609-branch/Source/JavaScriptCore/runtime/JSMapIterator.h</a></li>
<li><a href="#branchessafari609branchSourceJavaScriptCoreruntimeJSSetIteratorh">branches/safari-609-branch/Source/JavaScriptCore/runtime/JSSetIterator.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari609branchSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: \
branches/safari-609-branch/Source/JavaScriptCore/ChangeLog (259256 => 259257)</h4> \
<pre class="diff"><span> <span class="info">--- \
branches/safari-609-branch/Source/JavaScriptCore/ChangeLog 2020-03-31 00:42:28 UTC \
(rev 259256)
+++ branches/safari-609-branch/Source/JavaScriptCore/ChangeLog 2020-03-31 00:42:31 \
UTC (rev 259257) </span><span class="lines">@@ -1,5 +1,37 @@
</span><span class="cx"> 2020-03-30 Alan Coon <alancoon@apple.com>
</span><span class="cx">
</span><ins>+ Cherry-pick r258540. rdar://problem/61064830
+
+ [JSC] JSMapIterator and JSSetIterator are CellType
+ https://bugs.webkit.org/show_bug.cgi?id=209168
+ <rdar://problem/59705631>
+
+ Reviewed by Saam Barati.
+
+ They are JSCell, not JSObject since they are not used as a user-observable \
set/map iterators in JSC. + However, their JSType is ObjectType. They should use \
CellType instead. +
+ * runtime/JSMapIterator.h:
+ * runtime/JSSetIterator.h:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258540 \
268f45cc-cd09-0410-ab3c-d52691b4dbfc +
+ 2020-03-16 Yusuke Suzuki <ysuzuki@apple.com>
+
+ [JSC] JSMapIterator and JSSetIterator are CellType
+ https://bugs.webkit.org/show_bug.cgi?id=209168
+ <rdar://problem/59705631>
+
+ Reviewed by Saam Barati.
+
+ They are JSCell, not JSObject since they are not used as a \
user-observable set/map iterators in JSC. + However, their JSType is \
ObjectType. They should use CellType instead. +
+ * runtime/JSMapIterator.h:
+ * runtime/JSSetIterator.h:
+
+2020-03-30 Alan Coon <alancoon@apple.com>
+
</ins><span class="cx"> Cherry-pick r258452. rdar://problem/61064799
</span><span class="cx">
</span><span class="cx"> Missing arithMode for ArithAbs and ArithNegate in \
DFGClobberize </span></span></pre></div>
<a id="branchessafari609branchSourceJavaScriptCoreruntimeJSMapIteratorh"></a>
<div class="modfile"><h4>Modified: \
branches/safari-609-branch/Source/JavaScriptCore/runtime/JSMapIterator.h (259256 => \
259257)</h4> <pre class="diff"><span>
<span class="info">--- \
branches/safari-609-branch/Source/JavaScriptCore/runtime/JSMapIterator.h 2020-03-31 \
00:42:28 UTC (rev 259256)
+++ branches/safari-609-branch/Source/JavaScriptCore/runtime/JSMapIterator.h 2020-03-31 \
00:42:31 UTC (rev 259257) </span><span class="lines">@@ -32,6 +32,8 @@
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span><span class="cx"> // Now, it is only used for serialization.
</span><ins>+// FIXME: We should use JSInternalFieldObjectImpl to implement real \
JSMapIterator used in JSC. +// Currently, JSC is using final objects to implement \
MapIterator. </ins><span class="cx"> class JSMapIterator final : public JSCell {
</span><span class="cx"> typedef HashMapBucket<HashMapBucketDataKeyValue> \
HashMapBucketType; </span><span class="cx"> public:
</span><span class="lines">@@ -47,7 +49,7 @@
</span><span class="cx">
</span><span class="cx"> static Structure* createStructure(VM& vm, \
JSGlobalObject* globalObject, JSValue prototype) </span><span class="cx"> {
</span><del>- return Structure::create(vm, globalObject, prototype, \
TypeInfo(ObjectType, StructureFlags), info()); </del><ins>+ return \
Structure::create(vm, globalObject, prototype, TypeInfo(CellType, StructureFlags), \
info()); </ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static JSMapIterator* create(VM& vm, Structure* \
structure, JSMap* iteratedObject, IterationKind kind) </span></span></pre></div>
<a id="branchessafari609branchSourceJavaScriptCoreruntimeJSSetIteratorh"></a>
<div class="modfile"><h4>Modified: \
branches/safari-609-branch/Source/JavaScriptCore/runtime/JSSetIterator.h (259256 => \
259257)</h4> <pre class="diff"><span>
<span class="info">--- \
branches/safari-609-branch/Source/JavaScriptCore/runtime/JSSetIterator.h 2020-03-31 \
00:42:28 UTC (rev 259256)
+++ branches/safari-609-branch/Source/JavaScriptCore/runtime/JSSetIterator.h 2020-03-31 \
00:42:31 UTC (rev 259257) </span><span class="lines">@@ -32,6 +32,8 @@
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span><span class="cx"> // Now, it is only used for serialization.
</span><ins>+// FIXME: We should use JSInternalFieldObjectImpl to implement real \
JSSetIterator used in JSC. +// Currently, JSC is using final objects to implement \
SetIterator. </ins><span class="cx"> class JSSetIterator final : public JSCell {
</span><span class="cx"> typedef HashMapBucket<HashMapBucketDataKey> \
HashMapBucketType; </span><span class="cx"> public:
</span><span class="lines">@@ -47,7 +49,7 @@
</span><span class="cx">
</span><span class="cx"> static Structure* createStructure(VM& vm, \
JSGlobalObject* globalObject, JSValue prototype) </span><span class="cx"> {
</span><del>- return Structure::create(vm, globalObject, prototype, \
TypeInfo(ObjectType, StructureFlags), info()); </del><ins>+ return \
Structure::create(vm, globalObject, prototype, TypeInfo(CellType, StructureFlags), \
info()); </ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static JSSetIterator* create(VM& vm, Structure* \
structure, JSSet* iteratedObject, IterationKind kind) </span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic