[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [239559] trunk
From: ross.kirsling () sony ! com
Date: 2018-12-30 17:38:56
Message-ID: 20181230173857.5390510051CC () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[239559] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/239559">239559</a></dd> \
<dt>Author</dt> <dd>ross.kirsling@sony.com</dd> <dt>Date</dt> <dd>2018-12-30 09:38:56 \
-0800 (Sun, 30 Dec 2018)</dd> </dl>
<h3>Log Message</h3>
<pre>[JSC] Identifier validity should be based on ID_Start / ID_Continue properties
https://bugs.webkit.org/show_bug.cgi?id=193050
Reviewed by Yusuke Suzuki.
JSTests:
* test262.yaml:
* test262/expectations.yaml:
Mark 16 tests as passing.
Source/JavaScriptCore:
From https://tc39.github.io/ecma262/#sec-names-and-keywords:
UnicodeIDStart::
any Unicode code point with the Unicode property "ID_Start"
UnicodeIDContinue::
any Unicode code point with the Unicode property "ID_Continue"
* parser/Lexer.cpp:
(JSC::Lexer<T>::Lexer):
(JSC::isNonLatin1IdentStart):
(JSC::isNonLatin1IdentPart):
(JSC::isIdentPart):
(JSC::Lexer<T>::lex):
Ensure identifier start / part is based on ID_Start / ID_Continue.
(Implies a special case for U+00B7, which is Latin-1 but Other_ID_Continue.)
LayoutTests:
* sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt:
* sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt:
* sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt:
* sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt:
* sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt:
* sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt:
* sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt:
* sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt:
* sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt:
* sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt:
* sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt:
* sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt:
* sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt:
* sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt:
* sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt:
* sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt:
* sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt:
* sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt:
* sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt:
* sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt:
* sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt:
* sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt:
* sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt:
* sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt:
* sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt:
* sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt:
* sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt:
Update expectations for outdated tests.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTeststest262expectationsyaml">trunk/JSTests/test262/expectations.yaml</a></li>
<li><a href="#trunkJSTeststest262yaml">trunk/JSTests/test262.yaml</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_218S76_A11_T2expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_218S76_A11_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_218S76_A52_T2expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_218S76_A52_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_218S76_A53_T1expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_218S76_A53_T2expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_320S76_A11_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_320S76_A23expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_320S76_A31expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_320S76_A52_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_320S76_A52_T9expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_320S76_A53_T1expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_320S76_A53_T2expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_410S76_A11_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_410S76_A31expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_410S76_A52_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_410S76_A53_T1expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_410S76_A53_T2expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_500S76_A11_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_500S76_A31expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_500S76_A52_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_500S76_A53_T1expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_500S76_A53_T2expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_510S76_A11_T4expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_510S76_A11_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_510S76_A52_T4expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt</a></li>
<li><a href="#trunkLayoutTestssputnikUnicodeUnicode_510S76_A52_T6expectedtxt">trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserLexercpp">trunk/Source/JavaScriptCore/parser/Lexer.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (239558 => 239559)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2018-12-29 05:50:04 UTC (rev 239558)
+++ trunk/JSTests/ChangeLog 2018-12-30 17:38:56 UTC (rev 239559)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2018-12-30 Ross Kirsling <ross.kirsling@sony.com>
+
+ [JSC] Identifier validity should be based on ID_Start / ID_Continue \
properties + https://bugs.webkit.org/show_bug.cgi?id=193050
+
+ Reviewed by Yusuke Suzuki.
+
+ * test262.yaml:
+ * test262/expectations.yaml:
+ Mark 16 tests as passing.
+
</ins><span class="cx"> 2018-12-13 Yusuke Suzuki <yusukesuzuki@slowstart.org>
</span><span class="cx">
</span><span class="cx"> [BigInt] Support BigInt in JSON.stringify
</span></span></pre></div>
<a id="trunkJSTeststest262expectationsyaml"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/test262/expectations.yaml (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- trunk/JSTests/test262/expectations.yaml 2018-12-29 05:50:04 \
UTC (rev 239558)
+++ trunk/JSTests/test262/expectations.yaml 2018-12-30 17:38:56 UTC (rev 239559)
</span><span class="lines">@@ -6953,33 +6953,9 @@
</span><span class="cx"> test/language/global-code/script-decl-var-err.js:
</span><span class="cx"> default: 'Test262Error: Expected a TypeError to be thrown \
but no exception was thrown at all' </span><span class="cx"> strict mode: \
'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all' \
</span><del>-test/language/identifiers/other_id_continue-escaped.js:
- default: "SyntaxError: Invalid unicode escape in identifier: 'a\\u2118'"
- strict mode: "SyntaxError: Invalid unicode escape in identifier: \
'a\\u2118'"
-test/language/identifiers/other_id_continue.js:
- default: "SyntaxError: Invalid character '\\u2118'"
- strict mode: "SyntaxError: Invalid character '\\u2118'"
-test/language/identifiers/other_id_start-escaped.js:
- default: "SyntaxError: Invalid unicode escape in identifier: '\\u2118'"
- strict mode: "SyntaxError: Invalid unicode escape in identifier: \
'\\u2118'"
-test/language/identifiers/other_id_start.js:
- default: "SyntaxError: Invalid character '\\u2118'"
- strict mode: "SyntaxError: Invalid character '\\u2118'"
</del><span class="cx"> test/language/identifiers/val-yield-strict.js:
</span><span class="cx"> default: 'Test262: This statement should not be \
evaluated.' </span><span class="cx"> strict mode: "SyntaxError: Cannot use \
'yield' as a variable name in strict mode." \
</span><del>-test/language/identifiers/vertical-tilde-continue-escaped.js:
- default: 'Test262: This statement should not be evaluated.'
- strict mode: 'Test262: This statement should not be evaluated.'
-test/language/identifiers/vertical-tilde-continue.js:
- default: 'Test262: This statement should not be evaluated.'
- strict mode: 'Test262: This statement should not be evaluated.'
-test/language/identifiers/vertical-tilde-start-escaped.js:
- default: 'Test262: This statement should not be evaluated.'
- strict mode: 'Test262: This statement should not be evaluated.'
-test/language/identifiers/vertical-tilde-start.js:
- default: 'Test262: This statement should not be evaluated.'
- strict mode: 'Test262: This statement should not be evaluated.'
</del><span class="cx"> \
test/language/literals/numeric/numeric-separator-literal-bil-bd-nsl-bd.js: \
</span><span class="cx"> default: 'SyntaxError: No space between binary literal and \
identifier' </span><span class="cx"> strict mode: 'SyntaxError: No space between \
binary literal and identifier' </span></span></pre></div>
<a id="trunkJSTeststest262yaml"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/test262.yaml (239558 => 239559)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/test262.yaml 2018-12-29 05:50:04 UTC (rev \
239558)
+++ trunk/JSTests/test262.yaml 2018-12-30 17:38:56 UTC (rev 239559)
</span><span class="lines">@@ -89044,21 +89044,21 @@
</span><span class="cx"> - path: \
test262/test/language/identifier-resolution/unscopables.js </span><span class="cx"> \
cmd: runTest262 :normal, "NoException", \
["../../../harness/assert.js", "../../../harness/sta.js"], \
[:strict] </span><span class="cx"> - path: \
test262/test/language/identifiers/other_id_continue-escaped.js </span><del>- cmd: \
runTest262 :fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </del><ins>+ cmd: runTest262 :normal, \
"NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </ins><span class="cx"> - path: \
test262/test/language/identifiers/other_id_continue-escaped.js </span><del>- cmd: \
runTest262 :fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </del><ins>+ cmd: runTest262 \
:normal, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </ins><span class="cx"> - path: \
test262/test/language/identifiers/other_id_continue.js </span><del>- cmd: runTest262 \
:fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </del><ins>+ cmd: runTest262 :normal, \
"NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </ins><span class="cx"> - path: \
test262/test/language/identifiers/other_id_continue.js </span><del>- cmd: runTest262 \
:fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </del><ins>+ cmd: runTest262 \
:normal, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </ins><span class="cx"> - path: \
test262/test/language/identifiers/other_id_start-escaped.js </span><del>- cmd: \
runTest262 :fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </del><ins>+ cmd: runTest262 :normal, \
"NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </ins><span class="cx"> - path: \
test262/test/language/identifiers/other_id_start-escaped.js </span><del>- cmd: \
runTest262 :fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </del><ins>+ cmd: runTest262 \
:normal, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </ins><span class="cx"> - path: \
test262/test/language/identifiers/other_id_start.js </span><del>- cmd: runTest262 \
:fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </del><ins>+ cmd: runTest262 :normal, \
"NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </ins><span class="cx"> - path: \
test262/test/language/identifiers/other_id_start.js </span><del>- cmd: runTest262 \
:fail, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </del><ins>+ cmd: runTest262 \
:normal, "NoException", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </ins><span class="cx"> - path: \
test262/test/language/identifiers/part-digits-via-escape-hex.js </span><span \
class="cx"> cmd: runTest262 :normal, "NoException", \
["../../../harness/assert.js", "../../../harness/sta.js"], [] \
</span><span class="cx"> - path: \
test262/test/language/identifiers/part-digits-via-escape-hex.js </span><span \
class="lines">@@ -89598,21 +89598,21 @@ </span><span class="cx"> - path: \
test262/test/language/identifiers/vals-rus-alpha-upper.js </span><span class="cx"> \
cmd: runTest262 :normal, "NoException", \
["../../../harness/assert.js", "../../../harness/sta.js"], \
[:strict] </span><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-continue-escaped.js </span><del>- \
cmd: runTest262 :fail, "SyntaxError", \
["../../../harness/assert.js", "../../../harness/sta.js"], [] \
</del><ins>+ cmd: runTest262 :normal, "SyntaxError", \
["../../../harness/assert.js", "../../../harness/sta.js"], [] \
</ins><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-continue-escaped.js </span><del>- \
cmd: runTest262 :fail, "SyntaxError", \
["../../../harness/assert.js", "../../../harness/sta.js"], \
[:strict] </del><ins>+ cmd: runTest262 :normal, "SyntaxError", \
["../../../harness/assert.js", "../../../harness/sta.js"], \
[:strict] </ins><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-continue.js </span><del>- cmd: \
runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </del><ins>+ cmd: runTest262 :normal, \
"SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </ins><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-continue.js </span><del>- cmd: \
runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </del><ins>+ cmd: runTest262 \
:normal, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </ins><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-start-escaped.js </span><del>- cmd: \
runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </del><ins>+ cmd: runTest262 :normal, \
"SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </ins><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-start-escaped.js </span><del>- cmd: \
runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </del><ins>+ cmd: runTest262 \
:normal, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </ins><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-start.js </span><del>- cmd: \
runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </del><ins>+ cmd: runTest262 :normal, \
"SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [] </ins><span class="cx"> - path: \
test262/test/language/identifiers/vertical-tilde-start.js </span><del>- cmd: \
runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </del><ins>+ cmd: runTest262 \
:normal, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:strict] </ins><span class="cx"> - path: \
test262/test/language/import/dup-bound-names.js </span><span class="cx"> cmd: \
runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", \
"../../../harness/sta.js"], [:module] </span><span class="cx"> - path: \
test262/test/language/import/escaped-as-import-specifier.js \
</span></span></pre></div> <a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2018-12-29 05:50:04 UTC (rev \
239558)
+++ trunk/LayoutTests/ChangeLog 2018-12-30 17:38:56 UTC (rev 239559)
</span><span class="lines">@@ -1,3 +1,39 @@
</span><ins>+2018-12-30 Ross Kirsling <ross.kirsling@sony.com>
+
+ [JSC] Identifier validity should be based on ID_Start / ID_Continue \
properties + https://bugs.webkit.org/show_bug.cgi?id=193050
+
+ Reviewed by Yusuke Suzuki.
+
+ * sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt:
+ * sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt:
+ * sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt:
+ * sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt:
+ * sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt:
+ * sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt:
+ * sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt:
+ * sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt:
+ * sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt:
+ * sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt:
+ * sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt:
+ * sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt:
+ * sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt:
+ * sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt:
+ * sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt:
+ * sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt:
+ * sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt:
+ * sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt:
+ * sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt:
+ * sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt:
+ * sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt:
+ * sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt:
+ * sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt:
+ * sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt:
+ * sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt:
+ * sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt:
+ * sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt:
+ Update expectations for outdated tests.
+
</ins><span class="cx"> 2018-12-23 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed GTK+ gardening. Rebaseline \
fast/text/zero-font-size.html after r239539. </span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_218S76_A11_T2expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A1.1_T2
</span><span class="cx">
</span><del>-FAIL SputnikError: #2118
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_218S76_A11_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A1.1_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #2160
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_218S76_A52_T2expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T2
</span><span class="cx">
</span><del>-FAIL SputnikError: #2118
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_218S76_A52_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #2160
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_218S76_A53_T1expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T1
</span><span class="cx">
</span><del>-FAIL SputnikError: #01F6-01F9
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_218S76_A53_T2expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T2
</span><span class="cx">
</span><del>-FAIL SputnikError: #01F6-01F9
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_320S76_A11_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A1.1_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_320S76_A23expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A2.3
</span><span class="cx">
</span><del>-FAIL SputnikError: #1369
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_320S76_A31expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A3.1
</span><span class="cx">
</span><del>-FAIL SputnikError: #0221
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_320S76_A52_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_320S76_A52_T9expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T9
</span><span class="cx">
</span><del>-FAIL SputnikError: #1369
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_320S76_A53_T1expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T1
</span><span class="cx">
</span><del>-FAIL SputnikError: #0221
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_320S76_A53_T2expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T2
</span><span class="cx">
</span><del>-FAIL SputnikError: #0221
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_410S76_A11_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A1.1_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_410S76_A31expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A3.1
</span><span class="cx">
</span><del>-FAIL SputnikError: #0242-024F
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_410S76_A52_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_410S76_A53_T1expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T1
</span><span class="cx">
</span><del>-FAIL SputnikError: #0242-024F
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_410S76_A53_T2expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T2
</span><span class="cx">
</span><del>-FAIL SputnikError: #0242-024F
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_500S76_A11_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A1.1_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_500S76_A31expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A3.1
</span><span class="cx">
</span><del>-FAIL SputnikError: #02EC
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_500S76_A52_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_500S76_A53_T1expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T1
</span><span class="cx">
</span><del>-FAIL SputnikError: #02EC
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_500S76_A53_T2expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.3_T2
</span><span class="cx">
</span><del>-FAIL SputnikError: #02EC
</del><ins>+FAIL SputnikError: #00B7
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_510S76_A11_T4expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A1.1_T4
</span><span class="cx">
</span><del>-PASS
</del><ins>+FAIL SputnikError: #2E2F
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_510S76_A11_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A1.1_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_510S76_A52_T4expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T4
</span><span class="cx">
</span><del>-PASS
</del><ins>+FAIL SputnikError: #2E2F
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssputnikUnicodeUnicode_510S76_A52_T6expectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt 2018-12-30 \
17:38:56 UTC (rev 239559) </span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> S7.6_A5.2_T6
</span><span class="cx">
</span><del>-FAIL SputnikError: #16EE
</del><ins>+PASS
</ins><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (239558 => \
239559)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2018-12-29 05:50:04 UTC \
(rev 239558)
+++ trunk/Source/JavaScriptCore/ChangeLog 2018-12-30 17:38:56 UTC (rev 239559)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2018-12-30 Ross Kirsling <ross.kirsling@sony.com>
+
+ [JSC] Identifier validity should be based on ID_Start / ID_Continue \
properties + https://bugs.webkit.org/show_bug.cgi?id=193050
+
+ Reviewed by Yusuke Suzuki.
+
+ From https://tc39.github.io/ecma262/#sec-names-and-keywords:
+ UnicodeIDStart::
+ any Unicode code point with the Unicode property \
"ID_Start" + UnicodeIDContinue::
+ any Unicode code point with the Unicode property \
"ID_Continue" +
+ * parser/Lexer.cpp:
+ (JSC::Lexer<T>::Lexer):
+ (JSC::isNonLatin1IdentStart):
+ (JSC::isNonLatin1IdentPart):
+ (JSC::isIdentPart):
+ (JSC::Lexer<T>::lex):
+ Ensure identifier start / part is based on ID_Start / ID_Continue.
+ (Implies a special case for U+00B7, which is Latin-1 but Other_ID_Continue.)
+
</ins><span class="cx"> 2018-12-28 Yusuke Suzuki <yusukesuzuki@slowstart.org>
</span><span class="cx">
</span><span class="cx"> [JSC] Remove one indirection in \
JSObject::toStringName </span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserLexercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Lexer.cpp \
(239558 => 239559)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Lexer.cpp 2018-12-29 \
05:50:04 UTC (rev 239558)
+++ trunk/Source/JavaScriptCore/parser/Lexer.cpp 2018-12-30 17:38:56 UTC (rev 239559)
</span><span class="lines">@@ -57,6 +57,10 @@
</span><span class="cx"> CharacterZero,
</span><span class="cx"> CharacterNumber,
</span><span class="cx">
</span><ins>+ // For single-byte characters grandfathered into Other_ID_Continue \
-- namely just U+00B7 MIDDLE DOT. + // \
(http://unicode.org/reports/tr31/#Backward_Compatibility) + \
CharacterOtherIdentifierPart, +
</ins><span class="cx"> CharacterInvalid,
</span><span class="cx"> CharacterLineTerminator,
</span><span class="cx"> CharacterExclamationMark,
</span><span class="lines">@@ -278,7 +282,7 @@
</span><span class="cx"> /* 180 - Sk category */ CharacterInvalid,
</span><span class="cx"> /* 181 - Ll category */ CharacterIdentifierStart,
</span><span class="cx"> /* 182 - So category */ CharacterInvalid,
</span><del>-/* 183 - Po category */ CharacterInvalid,
</del><ins>+/* 183 - Po category */ CharacterOtherIdentifierPart,
</ins><span class="cx"> /* 184 - Sk category */ CharacterInvalid,
</span><span class="cx"> /* 185 - No category */ CharacterInvalid,
</span><span class="cx"> /* 186 - Ll category */ CharacterIdentifierStart,
</span><span class="lines">@@ -727,7 +731,7 @@
</span><span class="cx">
</span><span class="cx"> static NEVER_INLINE bool isNonLatin1IdentStart(UChar c)
</span><span class="cx"> {
</span><del>- return U_GET_GC_MASK(c) & U_GC_L_MASK;
</del><ins>+ return u_hasBinaryProperty(c, UCHAR_ID_START);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static ALWAYS_INLINE bool isLatin1(LChar)
</span><span class="lines">@@ -757,16 +761,15 @@
</span><span class="cx">
</span><span class="cx"> static NEVER_INLINE bool isNonLatin1IdentPart(UChar32 c)
</span><span class="cx"> {
</span><del>- // FIXME: ES6 says this should be based on the Unicode property \
ID_Continue now instead.
- return (U_GET_GC_MASK(c) & (U_GC_L_MASK | U_GC_MN_MASK | U_GC_MC_MASK | \
U_GC_ND_MASK | U_GC_PC_MASK)) || c == 0x200C || c == 0x200D; </del><ins>+ return \
u_hasBinaryProperty(c, UCHAR_ID_CONTINUE) || c == 0x200C || c == 0x200D; </ins><span \
class="cx"> } </span><span class="cx">
</span><span class="cx"> static ALWAYS_INLINE bool isIdentPart(LChar c)
</span><span class="cx"> {
</span><span class="cx"> // Character types are divided into two groups depending \
on whether they can be part of an </span><del>- // identifier or not. Those whose \
type value is less or equal than CharacterNumber can be </del><ins>+ // identifier \
or not. Those whose type value is less or equal than CharacterOtherIdentifierPart can \
be </ins><span class="cx"> // part of an identifier. (See the CharacterType \
definition for more details.) </span><del>- return typesOfLatin1Characters[c] \
<= CharacterNumber; </del><ins>+ return typesOfLatin1Characters[c] <= \
CharacterOtherIdentifierPart; </ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static ALWAYS_INLINE bool isIdentPart(UChar32 c)
</span><span class="lines">@@ -2312,6 +2315,7 @@
</span><span class="cx"> goto parseIdent;
</span><span class="cx">
</span><span class="cx"> FALLTHROUGH;
</span><ins>+ case CharacterOtherIdentifierPart:
</ins><span class="cx"> case CharacterInvalid:
</span><span class="cx"> m_lexErrorMessage = invalidCharacterMessage();
</span><span class="cx"> token = ERRORTOK;
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic