[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [239523] trunk
From: jiewen_tan () apple ! com
Date: 2018-12-21 23:27:28
Message-ID: 20181221232728.2456D10051CE () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[239523] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/239523">239523</a></dd> \
<dt>Author</dt> <dd>jiewen_tan@apple.com</dd> <dt>Date</dt> <dd>2018-12-21 15:27:27 \
-0800 (Fri, 21 Dec 2018)</dd> </dl>
<h3>Log Message</h3>
<pre>[WebAuthN] userPresence should always be true
https://bugs.webkit.org/show_bug.cgi?id=192835
<rdar://problem/46538788>
Reviewed by Brent Fulgham.
Source/WebCore:
In the current spec as of 7 August 2018, userPresence is suggested to set to the \
inverse of userVerification. This doesn't comply with the CTAP spec. Details in: \
https://github.com/w3c/webauthn/issues/1123. After discussing with other members of \
the working group, we decided to make userPresence always default to true.
Covered by exisiting tests.
* Modules/webauthn/fido/DeviceRequestConverter.cpp:
(fido::encodeGetAssertionRequestAsCBOR):
Tools:
* TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
(TestWebKitAPI::TEST):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebauthnfidoDeviceRequestConvertercpp">trunk/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebCoreFidoTestDatah">trunk/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (239522 => \
239523)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2018-12-21 23:26:05 UTC (rev \
239522)
+++ trunk/Source/WebCore/ChangeLog 2018-12-21 23:27:27 UTC (rev 239523)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2018-12-21 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><ins>+ [WebAuthN] userPresence should always be true
+ https://bugs.webkit.org/show_bug.cgi?id=192835
+ <rdar://problem/46538788>
+
+ Reviewed by Brent Fulgham.
+
+ In the current spec as of 7 August 2018, userPresence is suggested to set to \
the inverse of userVerification. + This doesn't comply with the CTAP spec. \
Details in: https://github.com/w3c/webauthn/issues/1123. + After discussing \
with other members of the working group, we decided to make userPresence always \
default to true. +
+ Covered by exisiting tests.
+
+ * Modules/webauthn/fido/DeviceRequestConverter.cpp:
+ (fido::encodeGetAssertionRequestAsCBOR):
+
+2018-12-21 Jiewen Tan <jiewen_tan@apple.com>
+
</ins><span class="cx"> [WebAuthN] Import an APDU coder from Chromium
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=192949
</span><span class="cx"> <rdar://problem/46879933>
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebauthnfidoDeviceRequestConvertercpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp (239522 => \
239523)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp 2018-12-21 \
23:26:05 UTC (rev 239522)
+++ trunk/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp 2018-12-21 \
23:27:27 UTC (rev 239523) </span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> requireUserVerification = false;
</span><span class="cx"> }
</span><span class="cx"> optionMap[CBORValue(kUserVerificationMapKey)] = \
CBORValue(requireUserVerification); </span><del>- \
optionMap[CBORValue(kUserPresenceMapKey)] = CBORValue(!requireUserVerification); \
</del><ins>+ optionMap[CBORValue(kUserPresenceMapKey)] = CBORValue(true); \
</ins><span class="cx"> </span><span class="cx"> if (!optionMap.empty())
</span><span class="cx"> cborMap[CBORValue(5)] = \
CBORValue(WTFMove(optionMap)); </span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (239522 => 239523)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2018-12-21 23:26:05 UTC (rev 239522)
+++ trunk/Tools/ChangeLog 2018-12-21 23:27:27 UTC (rev 239523)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2018-12-21 Jiewen Tan <jiewen_tan@apple.com>
+
+ [WebAuthN] userPresence should always be true
+ https://bugs.webkit.org/show_bug.cgi?id=192835
+ <rdar://problem/46538788>
+
+ Reviewed by Brent Fulgham.
+
+ * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
+ (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2018-12-19 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Add support to run-benchmark to use non-default \
copies of the browser apps </span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebCoreFidoTestDatah"></a>
<div class="modfile"><h4>Modified: \
trunk/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h (239522 => 239523)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h 2018-12-21 23:26:05 UTC (rev \
239522)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h 2018-12-21 23:27:27 UTC \
(rev 239523) </span><span class="lines">@@ -344,8 +344,8 @@
</span><span class="cx"> 0xa2,
</span><span class="cx"> // key -"up"
</span><span class="cx"> 0x62, 0x75, 0x70,
</span><del>- // value - False(20)
- 0xf4,
</del><ins>+ // value - True(21)
+ 0xf5,
</ins><span class="cx"> // key - "uv"
</span><span class="cx"> 0x62, 0x75, 0x76,
</span><span class="cx"> // value - True(21)
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic