[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [239516] trunk
From: justin_michaud () apple ! com
Date: 2018-12-21 21:33:04
Message-ID: 20181221213304.3033C10051CE () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[239516] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/239516">239516</a></dd> \
<dt>Author</dt> <dd>justin_michaud@apple.com</dd> <dt>Date</dt> <dd>2018-12-21 \
13:33:03 -0800 (Fri, 21 Dec 2018)</dd> </dl>
<h3>Log Message</h3>
<pre>CSS variables don't work for colors in "border" property
https://bugs.webkit.org/show_bug.cgi?id=192922
Reviewed by Simon Fraser.
Source/WebCore:
ParseColorFunction no longer consumes anything if the color was not valid.
Test: css-custom-properties-api/border-variable-parsing.html
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
LayoutTests:
* css-custom-properties-api/border-variable-parsing-expected.html: Added.
* css-custom-properties-api/border-variable-parsing.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSPropertyParserHelperscpp">trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscsscustompropertiesapibordervariableparsingexpectedhtml" \
>trunk/LayoutTests/css-custom-properties-api/border-variable-parsing-expected.html</a></li>
>
<li><a href="#trunkLayoutTestscsscustompropertiesapibordervariableparsinghtml">trunk/LayoutTests/css-custom-properties-api/border-variable-parsing.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (239515 => \
239516)</h4> <pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2018-12-21 20:46:03 UTC (rev \
239515)
+++ trunk/LayoutTests/ChangeLog 2018-12-21 21:33:03 UTC (rev 239516)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2018-12-21 Justin Michaud <justin_michaud@apple.com>
+
+ CSS variables don't work for colors in "border" property
+ https://bugs.webkit.org/show_bug.cgi?id=192922
+
+ Reviewed by Simon Fraser.
+
+ * css-custom-properties-api/border-variable-parsing-expected.html: Added.
+ * css-custom-properties-api/border-variable-parsing.html: Added.
+
</ins><span class="cx"> 2018-12-21 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Synchronous media query evaluation could destroy \
current Frame/FrameView. </span></span></pre></div>
<a id="trunkLayoutTestscsscustompropertiesapibordervariableparsingexpectedhtml"></a>
<div class="addfile"><h4>Added: \
trunk/LayoutTests/css-custom-properties-api/border-variable-parsing-expected.html (0 \
=> 239516)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/css-custom-properties-api/border-variable-parsing-expected.html \
(rev 0)
+++ trunk/LayoutTests/css-custom-properties-api/border-variable-parsing-expected.html 2018-12-21 \
21:33:03 UTC (rev 239516) </span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+<style>
+#el1 {
+ --foreground: 100;
+ border: 30px dashed rgb(100, 0, 100);
+}
+#el2 {
+ --foreground: 100;
+ border: 30px rgb(100, 0, 100) dashed;
+}
+div {
+ width: 150px;
+ height: 150px;
+}
+</style>
+<div id="el1"></div>
+<div id="el2"></div>
</ins></span></pre></div>
<a id="trunkLayoutTestscsscustompropertiesapibordervariableparsinghtml"></a>
<div class="addfile"><h4>Added: \
trunk/LayoutTests/css-custom-properties-api/border-variable-parsing.html (0 => \
239516)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/css-custom-properties-api/border-variable-parsing.html \
(rev 0)
+++ trunk/LayoutTests/css-custom-properties-api/border-variable-parsing.html 2018-12-21 \
21:33:03 UTC (rev 239516) </span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+<style>
+#el1 {
+ --foreground: 100;
+ border: 30px dashed rgb(100, 0, var(--foreground));
+}
+#el2 {
+ --foreground: 100;
+ border: 30px rgb(100, 0, var(--foreground)) dashed;
+}
+div {
+ width: 150px;
+ height: 150px;
+}
+</style>
+<div id="el1"></div>
+<div id="el2"></div>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (239515 => \
239516)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2018-12-21 20:46:03 UTC (rev \
239515)
+++ trunk/Source/WebCore/ChangeLog 2018-12-21 21:33:03 UTC (rev 239516)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2018-12-21 Justin Michaud <justin_michaud@apple.com>
+
+ CSS variables don't work for colors in "border" property
+ https://bugs.webkit.org/show_bug.cgi?id=192922
+
+ Reviewed by Simon Fraser.
+
+ ParseColorFunction no longer consumes anything if the color was not valid.
+
+ Test: css-custom-properties-api/border-variable-parsing.html
+
+ * css/parser/CSSPropertyParserHelpers.cpp:
+ (WebCore::CSSPropertyParserHelpers::parseColorFunction):
+
</ins><span class="cx"> 2018-12-21 Justin Fan <justin_fan@apple.com>
</span><span class="cx">
</span><span class="cx"> [WebGPU] GPUBindGroupLayout refactoring: no HashMap, \
and failure logging </span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSPropertyParserHelperscpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (239515 => 239516)</h4> \
<pre class="diff"><span> <span class="info">--- \
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2018-12-21 20:46:03 UTC \
(rev 239515)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2018-12-21 21:33:03 \
UTC (rev 239516) </span><span class="lines">@@ -681,7 +681,8 @@
</span><span class="cx"> default:
</span><span class="cx"> return Color();
</span><span class="cx"> }
</span><del>- range = colorRange;
</del><ins>+ if (color.isValid())
+ range = colorRange;
</ins><span class="cx"> return color;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic