[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [239455] trunk
From:       mark.lam () apple ! com
Date:       2018-12-20 18:51:49
Message-ID: 20181220185149.4E83810051CC () svn ! webkit ! org
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[239455] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/239455">239455</a></dd> \
<dt>Author</dt> <dd>mark.lam@apple.com</dd> <dt>Date</dt> <dd>2018-12-20 10:51:49 \
-0800 (Thu, 20 Dec 2018)</dd> </dl>

<h3>Log Message</h3>
<pre>Fix a typo in slow_path_construct_arityCheck and operationConstructArityCheck.
https://bugs.webkit.org/show_bug.cgi?id=192939
&lt;rdar://problem/46869516&gt;

Reviewed by Keith Miller.

JSTests:

* stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js: \
Added.

Source/JavaScriptCore:

* jit/JITOperations.cpp:
* runtime/CommonSlowPaths.cpp:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
 <li><a href="#trunkSourceJavaScriptCorejitJITOperationscpp">trunk/Source/JavaScriptCore/jit/JITOperations.cpp</a></li>
 <li><a href="#trunkSourceJavaScriptCoreruntimeCommonSlowPathscpp">trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp</a></li>
 </ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkJSTestsstressstackoverflowframeforconstructarityCheckshoulduseconst \
ructcodeBlockjs">trunk/JSTests/stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (239454 => 239455)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog	2018-12-20 18:42:45 UTC (rev 239454)
+++ trunk/JSTests/ChangeLog	2018-12-20 18:51:49 UTC (rev 239455)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2018-12-20  Mark Lam  &lt;mark.lam@apple.com&gt;
+
+        Fix a typo in slow_path_construct_arityCheck and \
operationConstructArityCheck. +        https://bugs.webkit.org/show_bug.cgi?id=192939
+        &lt;rdar://problem/46869516&gt;
+
+        Reviewed by Keith Miller.
+
+        * stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js: \
Added. +
</ins><span class="cx"> 2018-12-20  Tadeu Zagallo  &lt;tzagallo@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         WTF::String and StringImpl overflow MaxLength
</span></span></pre></div>
<a id="trunkJSTestsstressstackoverflowframeforconstructarityCheckshoulduseconstructcodeBlockjs"></a>
 <div class="addfile"><h4>Added: \
trunk/JSTests/stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js \
(0 => 239455)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/JSTests/stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js	 \
                (rev 0)
+++ trunk/JSTests/stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js	2018-12-20 \
18:51:49 UTC (rev 239455) </span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+//@ requireOptions(&quot;--maxPerThreadStackUsage=1572864&quot;)
+
+function foo(a, b, c) {
+    try {
+        throw new Error();
+    } catch {
+        hello();
+    }
+};
+
+function Bar(d, e) {
+    hello();
+}
+
+function hello(f) {
+    new Bar(0);
+};
+
+var exception;
+try {
+    foo();
+} catch(e) {
+    exception = e;
+}
+
+if (exception != &quot;RangeError: Maximum call stack size exceeded.&quot;)
+    throw &quot;FAILED&quot;;
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (239454 => \
239455)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog	2018-12-20 18:42:45 UTC \
                (rev 239454)
+++ trunk/Source/JavaScriptCore/ChangeLog	2018-12-20 18:51:49 UTC (rev 239455)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2018-12-20  Mark Lam  &lt;mark.lam@apple.com&gt;
+
+        Fix a typo in slow_path_construct_arityCheck and \
operationConstructArityCheck. +        https://bugs.webkit.org/show_bug.cgi?id=192939
+        &lt;rdar://problem/46869516&gt;
+
+        Reviewed by Keith Miller.
+
+        * jit/JITOperations.cpp:
+        * runtime/CommonSlowPaths.cpp:
+
</ins><span class="cx"> 2018-12-20  Caio Lima  &lt;ticaiolima@gmail.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [BigInt] We should enable CSE into arithmetic \
operations that speculate BigIntUse </span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITOperationscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITOperations.cpp \
(239454 => 239455)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITOperations.cpp	2018-12-20 \
                18:42:45 UTC (rev 239454)
+++ trunk/Source/JavaScriptCore/jit/JITOperations.cpp	2018-12-20 18:51:49 UTC (rev \
239455) </span><span class="lines">@@ -130,7 +130,7 @@
</span><span class="cx"> 
</span><span class="cx">     int32_t missingArgCount = \
CommonSlowPaths::arityCheckFor(exec, *vm, CodeForConstruct); </span><span class="cx"> \
if (UNLIKELY(missingArgCount &lt; 0)) { </span><del>-        CodeBlock* codeBlock = \
CommonSlowPaths::codeBlockFromCallFrameCallee(exec, CodeForCall); </del><ins>+        \
CodeBlock* codeBlock = CommonSlowPaths::codeBlockFromCallFrameCallee(exec, \
CodeForConstruct); </ins><span class="cx">         \
exec-&gt;convertToStackOverflowFrame(*vm, codeBlock); </span><span class="cx">        \
NativeCallFrameTracer tracer(vm, exec); </span><span class="cx">         \
throwStackOverflowError(vm-&gt;topCallFrame, scope); </span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeCommonSlowPathscpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp (239454 => 239455)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp	2018-12-20 18:42:45 UTC (rev \
                239454)
+++ trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp	2018-12-20 18:51:49 UTC \
(rev 239455) </span><span class="lines">@@ -194,7 +194,7 @@
</span><span class="cx">     BEGIN();
</span><span class="cx">     int slotsToAdd = CommonSlowPaths::arityCheckFor(exec, \
vm, CodeForConstruct); </span><span class="cx">     if (UNLIKELY(slotsToAdd &lt; 0)) \
{ </span><del>-        CodeBlock* codeBlock = \
CommonSlowPaths::codeBlockFromCallFrameCallee(exec, CodeForCall); </del><ins>+        \
CodeBlock* codeBlock = CommonSlowPaths::codeBlockFromCallFrameCallee(exec, \
CodeForConstruct); </ins><span class="cx">         \
exec-&gt;convertToStackOverflowFrame(vm, codeBlock); </span><span class="cx">         \
NativeCallFrameTracer tracer(&amp;vm, exec); </span><span class="cx">         \
ErrorHandlingScope errorScope(vm); </span></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic