'[webkit-changes] [235683] trunk'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [235683] trunk
From:       commit-queue () webkit ! org
Date:       2018-09-05 19:03:09
Message-ID: 20180905190310.08A8710051CA () svn ! webkit ! org
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[235683] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/235683">235683</a></dd> \
<dt>Author</dt> <dd>commit-queue@webkit.org</dd> <dt>Date</dt> <dd>2018-09-05 \
12:03:09 -0700 (Wed, 05 Sep 2018)</dd> </dl>

<h3>Log Message</h3>
<pre>Added runtime feature flag for web API statistics
https://bugs.webkit.org/show_bug.cgi?id=189211

Patch by Woodrow Wang &lt;woodrow_wang@apple.com&gt; on 2018-09-05
Reviewed by Daniel Bates.

Source/WebCore:

Added functionality to get and set the runtime flag.

* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebAPIStatisticsEnabled):
(WebCore::RuntimeEnabledFeatures::webAPIStatisticsEnabled const):

Source/WebKit:

Added functionality to set the runtime flag with a JavaScript exposed function
for testing.

* Shared/WebPreferences.yaml:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Tools:

Added functionality to set the runtime flag with a JavaScript exposed function
for testing.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setWebAPIStatisticsEnabled):
* WebKitTestRunner/InjectedBundle/TestRunner.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageRuntimeEnabledFeaturesh">trunk/Source/WebCore/page/RuntimeEnabledFeatures.h</a></li>
 <li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitSharedWebPreferencesyaml">trunk/Source/WebKit/Shared/WebPreferences.yaml</a></li>
 <li><a href="#trunkSourceWebKitWebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
 <li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleBindingsTestRunneridl">trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl</a></li>
 <li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp</a></li>
 <li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (235682 => \
235683)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog	2018-09-05 18:54:54 UTC (rev \
                235682)
+++ trunk/Source/WebCore/ChangeLog	2018-09-05 19:03:09 UTC (rev 235683)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2018-09-05  Woodrow Wang  &lt;woodrow_wang@apple.com&gt;
+
+        Added runtime feature flag for web API statistics
+        https://bugs.webkit.org/show_bug.cgi?id=189211
+
+        Reviewed by Daniel Bates.
+
+        Added functionality to get and set the runtime flag.
+
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setWebAPIStatisticsEnabled):
+        (WebCore::RuntimeEnabledFeatures::webAPIStatisticsEnabled const):
+
</ins><span class="cx"> 2018-09-05  Youenn Fablet  &lt;youenn@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Move replaceTrack logic to \
LibWebRTCPeerConnectionBackend </span></span></pre></div>
<a id="trunkSourceWebCorepageRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h \
(235682 => 235683)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-09-05 \
                18:54:54 UTC (rev 235682)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-09-05 19:03:09 UTC (rev \
235683) </span><span class="lines">@@ -282,6 +282,9 @@
</span><span class="cx">     void setAttrStyleEnabled(bool isEnabled) { \
m_attrStyleEnabled = isEnabled; } </span><span class="cx">     bool \
attrStyleEnabled() const { return m_attrStyleEnabled; } </span><span class="cx"> 
</span><ins>+    void setWebAPIStatisticsEnabled(bool isEnabled) { \
m_webAPIStatisticsEnabled = isEnabled; } +    bool webAPIStatisticsEnabled() const { \
return m_webAPIStatisticsEnabled; } +
</ins><span class="cx">     WEBCORE_EXPORT static RuntimeEnabledFeatures&amp; \
sharedFeatures(); </span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="lines">@@ -425,6 +428,8 @@
</span><span class="cx"> 
</span><span class="cx">     bool m_attrStyleEnabled { false };
</span><span class="cx"> 
</span><ins>+    bool m_webAPIStatisticsEnabled { false };
+
</ins><span class="cx">     friend class \
WTF::NeverDestroyed&lt;RuntimeEnabledFeatures&gt;; </span><span class="cx"> };
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (235682 => \
235683)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog	2018-09-05 18:54:54 UTC (rev \
                235682)
+++ trunk/Source/WebKit/ChangeLog	2018-09-05 19:03:09 UTC (rev 235683)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2018-09-05  Woodrow Wang  &lt;woodrow_wang@apple.com&gt;
+
+        Added runtime feature flag for web API statistics
+        https://bugs.webkit.org/show_bug.cgi?id=189211
+
+        Reviewed by Daniel Bates.
+
+        Added functionality to set the runtime flag with a JavaScript exposed \
function +        for testing.
+
+        * Shared/WebPreferences.yaml:
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+
</ins><span class="cx"> 2018-09-05  Jer Noble  &lt;jer.noble@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Add MediaCapabilities as an Experimental Feature
</span></span></pre></div>
<a id="trunkSourceWebKitSharedWebPreferencesyaml"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml \
(235682 => 235683)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-09-05 \
                18:54:54 UTC (rev 235682)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-09-05 19:03:09 UTC (rev \
235683) </span><span class="lines">@@ -1333,3 +1333,11 @@
</span><span class="cx">   humanReadableDescription: &quot;Enable Media Source Codec \
Switching through changeType()&quot; </span><span class="cx">   category: \
experimental </span><span class="cx">   condition: ENABLE(MEDIA_SOURCE)
</span><ins>+
+WebAPIStatisticsEnabled:
+  type: bool
+  defaultValue: false
+  humanReadableName: &quot;Web API Statistics&quot;
+  humanReadableDescription: &quot;Enable Web API Statistics&quot;
+  webcoreBinding: RuntimeEnabledFeatures
+  category: experimental
</ins></span></pre></div>
<a id="trunkSourceWebKitWebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp (235682 => \
235683)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp	2018-09-05 18:54:54 \
                UTC (rev 235682)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp	2018-09-05 \
19:03:09 UTC (rev 235683) </span><span class="lines">@@ -250,6 +250,9 @@
</span><span class="cx">         \
RuntimeEnabledFeatures::sharedFeatures().setIsSecureContextAttributeEnabled(enabled); \
</span><span class="cx">     } </span><span class="cx"> 
</span><ins>+    if (preference == &quot;WebKitWebAPIStatisticsEnabled&quot;)
+        RuntimeEnabledFeatures::sharedFeatures().setWebAPIStatisticsEnabled(enabled);
 +
</ins><span class="cx">     // Map the names used in LayoutTests with the names used \
in WebCore::Settings and WebPreferencesStore. </span><span class="cx"> #define \
FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \ </span><span class="cx">     \
macro(WebKitJavaEnabled, JavaEnabled, javaEnabled) \ </span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (235682 => 235683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog	2018-09-05 18:54:54 UTC (rev 235682)
+++ trunk/Tools/ChangeLog	2018-09-05 19:03:09 UTC (rev 235683)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2018-09-05  Woodrow Wang  &lt;woodrow_wang@apple.com&gt;
+
+        Added runtime feature flag for web API statistics
+        https://bugs.webkit.org/show_bug.cgi?id=189211
+
+        Reviewed by Daniel Bates.
+
+        Added functionality to set the runtime flag with a JavaScript exposed \
function +        for testing.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setWebAPIStatisticsEnabled):
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
</ins><span class="cx"> 2018-09-05  Ross Kirsling  &lt;ross.kirsling@sony.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Add WinCairo to bot watcher's dashboard.
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleBindingsTestRunneridl"></a>
<div class="modfile"><h4>Modified: \
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl (235682 => \
235683)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl	2018-09-05 \
                18:54:54 UTC (rev 235682)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl	2018-09-05 \
19:03:09 UTC (rev 235683) </span><span class="lines">@@ -324,6 +324,8 @@
</span><span class="cx">     void setWebRTCUnifiedPlanEnabled(boolean value);
</span><span class="cx">     void setCustomUserAgent(DOMString userAgent);
</span><span class="cx"> 
</span><ins>+    void setWebAPIStatisticsEnabled(boolean value);
+
</ins><span class="cx">     void terminateNetworkProcess();
</span><span class="cx">     void terminateServiceWorkerProcess();
</span><span class="cx">     void terminateStorageProcess();
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (235682 => 235683)</h4> \
<pre class="diff"><span> <span class="info">--- \
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2018-09-05 18:54:54 UTC \
                (rev 235682)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2018-09-05 19:03:09 \
UTC (rev 235683) </span><span class="lines">@@ -455,6 +455,13 @@
</span><span class="cx">     \
WKBundlePostSynchronousMessage(InjectedBundle::singleton().bundle(), \
messageName.get(), toWK(userAgent).get(), nullptr); </span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void TestRunner::setWebAPIStatisticsEnabled(bool enabled)
+{
+    WKRetainPtr&lt;WKStringRef&gt; key(AdoptWK, \
WKStringCreateWithUTF8CString(&quot;WebKitWebAPIStatisticsEnabled&quot;)); +    \
auto&amp; injectedBundle = InjectedBundle::singleton(); +    \
WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), \
injectedBundle.pageGroup(), key.get(), enabled); +}
+
</ins><span class="cx"> void TestRunner::setModernMediaControlsEnabled(bool enabled)
</span><span class="cx"> {
</span><span class="cx">     WKRetainPtr&lt;WKStringRef&gt; key(AdoptWK, \
WKStringCreateWithUTF8CString(&quot;WebKitModernMediaControlsEnabled&quot;)); \
</span></span></pre></div> <a \
id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh"></a> <div \
class="modfile"><h4>Modified: \
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (235682 => 235683)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h	2018-09-05 18:54:54 UTC (rev \
                235682)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h	2018-09-05 19:03:09 UTC \
(rev 235683) </span><span class="lines">@@ -133,6 +133,7 @@
</span><span class="cx">     void setMDNSICECandidatesEnabled(bool);
</span><span class="cx">     void setWebRTCUnifiedPlanEnabled(bool);
</span><span class="cx">     void setCustomUserAgent(JSStringRef);
</span><ins>+    void setWebAPIStatisticsEnabled(bool);
</ins><span class="cx"> 
</span><span class="cx">     // Special DOM functions.
</span><span class="cx">     void clearBackForwardList();
</span></span></pre>
</div>
</div>

</body>
</html>

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[prev in list] [next in list] [prev in thread] [next in thread] 