[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [216104] trunk
From: simon.fraser () apple ! com
Date: 2017-05-02 23:06:13
Message-ID: 20170502230613.29C8110195E1 () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[216104] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/216104">216104</a></dd> \
<dt>Author</dt> <dd>simon.fraser@apple.com</dd> <dt>Date</dt> <dd>2017-05-02 16:06:13 \
-0700 (Tue, 02 May 2017)</dd> </dl>
<h3>Log Message</h3>
<pre>Dynamically added position:fixed element is in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=170280
rdar://problem/31374008
Reviewed by Tim Horton.
Source/WebKit2:
Layers for position:fixed elements have their positions reconciled after scrolls
via AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions() and \
GraphicsLayerCA::syncPosition(), which updates the GraphicsLayer's position, but does \
not push it to the PlatformCALayer.
This bug was a case where a position:fixed element gained a fixed ancestor, so had a \
GraphicsLayerCA whose position had been updated via syncPosition() in the past. A \
subsequent layout updated the GraphicsLayerCA position, but to a value that was the \
same as its pre-sync position, so the PlatformCALayerRemote's position didn't change, \
but there was no signal to the UI process to restore the layer's pre-scrolled \
position.
Fix by avoiding the early return in PlatformCALayerRemote::setPosition(), to ensure \
that GraphicsLayerCA geometry updates in the web process always send new positions to \
the UI process.
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setPosition):
LayoutTests:
* scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html: Added.
* scrollingcoordinator/ios/nested-fixed-layer-positions.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp">trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsscrollingcoordinatoriosnestedfixedlayerpositionsexpected \
html">trunk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html</a></li>
<li><a href="#trunkLayoutTestsscrollingcoordinatoriosnestedfixedlayerpositionshtml">t \
runk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html</a></li> \
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (216103 => \
216104)</h4> <pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-05-02 23:06:09 UTC (rev \
216103)
+++ trunk/LayoutTests/ChangeLog 2017-05-02 23:06:13 UTC (rev 216104)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-05-02 Simon Fraser <simon.fraser@apple.com>
+
+ Dynamically added position:fixed element is in the wrong place
+ https://bugs.webkit.org/show_bug.cgi?id=170280
+ rdar://problem/31374008
+
+ Reviewed by Tim Horton.
+
+ * scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html: \
Added. + * scrollingcoordinator/ios/nested-fixed-layer-positions.html: Added.
+
</ins><span class="cx"> 2017-05-02 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Move flaky expectation for \
svg/animations/getCurrentTime-pause-unpause.html ios-wk1 to ios TestExpectations \
file. </span></span></pre></div>
<a id="trunkLayoutTestsscrollingcoordinatoriosnestedfixedlayerpositionsexpectedhtml"></a>
<div class="addfile"><h4>Added: \
trunk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html \
(0 => 216104)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html \
(rev 0)
+++ trunk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html 2017-05-02 \
23:06:13 UTC (rev 216104) </span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ \
useFlexibleViewport=true ] --> +
+<html>
+<head>
+ <meta name="viewport" content="initial-scale=1.0">
+ <style>
+ body {
+ height: 2000px;
+ margin: 0;
+ }
+
+ .fixed {
+ position: fixed;
+ }
+
+ .fixed-bar {
+ position: fixed;
+ top: 10px;
+ left: 0;
+ height: 100px;
+ width: 400px;
+ background-color: blue;
+ }
+ </style>
+</head>
+<body class="fixed">
+ <div class="fixed-bar"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsscrollingcoordinatoriosnestedfixedlayerpositionshtml"></a>
<div class="addfile"><h4>Added: \
trunk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html (0 => \
216104)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html \
(rev 0)
+++ trunk/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html 2017-05-02 \
23:06:13 UTC (rev 216104) </span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ \
useFlexibleViewport=true ] --> +
+<html>
+<head>
+ <meta name="viewport" content="initial-scale=1.0">
+ <style>
+ body {
+ height: 2000px;
+ margin: 0;
+ }
+
+ .fixed {
+ position: fixed;
+ }
+
+ .fixed-bar {
+ position: fixed;
+ top: 10px;
+ left: 0;
+ height: 100px;
+ width: 400px;
+ background-color: blue;
+ }
+ </style>
+ <script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function getScrollDownUIScript()
+ {
+ return `(function() {
+ uiController.scrollToOffset(0, 300);
+
+ uiController.didEndScrollingCallback = function() {
+ uiController.uiScriptComplete();
+ };
+ })();`;
+ }
+
+ function makeBodyFixed()
+ {
+ document.body.classList.add('fixed');
+ testRunner.notifyDone();
+ }
+
+ function doTest()
+ {
+ if (!testRunner.runUIScript)
+ return
+
+ testRunner.runUIScript(getScrollDownUIScript(), function() {
+ makeBodyFixed();
+ });
+ }
+
+ window.addEventListener('load', doTest, false);
+ </script>
+</head>
+<body>
+ <div class="fixed-bar"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (216103 => \
216104)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-05-02 23:06:09 UTC (rev \
216103)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-02 23:06:13 UTC (rev 216104)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2017-05-02 Simon Fraser <simon.fraser@apple.com>
+
+ Dynamically added position:fixed element is in the wrong place
+ https://bugs.webkit.org/show_bug.cgi?id=170280
+ rdar://problem/31374008
+
+ Reviewed by Tim Horton.
+
+ Layers for position:fixed elements have their positions reconciled after \
scrolls + via \
AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions() and \
GraphicsLayerCA::syncPosition(), + which updates the GraphicsLayer's position, \
but does not push it to the PlatformCALayer. +
+ This bug was a case where a position:fixed element gained a fixed ancestor, \
so had a GraphicsLayerCA whose + position had been updated via syncPosition() \
in the past. A subsequent layout updated the GraphicsLayerCA position, + but \
to a value that was the same as its pre-sync position, so the PlatformCALayerRemote's \
position didn't change, + but there was no signal to the UI process to restore \
the layer's pre-scrolled position. +
+ Fix by avoiding the early return in PlatformCALayerRemote::setPosition(), to \
ensure that GraphicsLayerCA + geometry updates in the web process always send \
new positions to the UI process. +
+ * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
+ (WebKit::PlatformCALayerRemote::setPosition):
+
</ins><span class="cx"> 2017-05-02 Gwang Yoon Hwang <yoon@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Drop coordinated surfaces from the compositing \
thread as soon as possible </span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp (216103 => \
216104)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2017-05-02 \
23:06:09 UTC (rev 216103)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2017-05-02 \
23:06:13 UTC (rev 216104) </span><span class="lines">@@ -452,9 +452,9 @@
</span><span class="cx">
</span><span class="cx"> void PlatformCALayerRemote::setPosition(const \
FloatPoint3D& value) </span><span class="cx"> {
</span><del>- if (value == m_properties.position)
- return;
-
</del><ins>+ // We can't early return here if the position has not changed, since \
GraphicsLayerCA::syncPosition() may have changed + // the GraphicsLayer position \
(which doesn't force a geometry update) but we want a subsequent \
GraphicsLayerCA::setPosition() + // to push a new position to the UI process, even \
though our m_properties.position hasn't changed. </ins><span class="cx"> \
m_properties.position = value; </span><span class="cx"> \
m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::PositionChanged); \
</span><span class="cx"> } </span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic